#4342 re-fetch cleartext signed message when HTML version is corrupted #4961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 19, 2023 12:30
…cleartext-signed-messages
…cleartext-signed-messages
rrrooommmaaa
commented
Feb 23, 2023
| testWithBrowser('ci.tests.gmail', async (t, browser) => { | ||
| const acctEmail = 'ci.tests.gmail@flowcrypt.test'; | ||
| const settingsPage = await browser.newExtensionSettingsPage(t, acctEmail); | ||
| const accessToken = await BrowserRecipe.getGoogleAccessToken(settingsPage, acctEmail); // todo: include in t? |
There was a problem hiding this comment.
I think we can simplify some tests if we can extract google access token from t -- we can put it there in a helper method like setUpCommonAcct, so we don't have to open a dummy page just to retrieve the access token.
There was a problem hiding this comment.
Yeah, it'll be nice to have access token available through t. Probably we can include such improvement when working on part 2 of #4494, there we can fetch access token when configuring test account.
rrrooommmaaa
changed the title
sosnovsky
reviewed
Feb 23, 2023
| testWithBrowser('ci.tests.gmail', async (t, browser) => { | ||
| const acctEmail = 'ci.tests.gmail@flowcrypt.test'; | ||
| const settingsPage = await browser.newExtensionSettingsPage(t, acctEmail); | ||
| const accessToken = await BrowserRecipe.getGoogleAccessToken(settingsPage, acctEmail); // todo: include in t? |
There was a problem hiding this comment.
Yeah, it'll be nice to have access token available through t. Probably we can include such improvement when working on part 2 of #4494, there we can fetch access token when configuring test account.
added 2 commits
February 24, 2023 08:02
…cleartext-signed-messages
sosnovsky
approved these changes
Feb 24, 2023
| testWithBrowser('ci.tests.gmail', async (t, browser) => { | ||
| const acctEmail = 'ci.tests.gmail@flowcrypt.test'; | ||
| const settingsPage = await browser.newExtensionSettingsPage(t, acctEmail); | ||
| const accessToken = await BrowserRecipe.getGoogleAccessToken(settingsPage, acctEmail); // todo: include in t? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-fetches cleartext signed message from
text/plainalternative part if signature verification failsclose #4342
issue #4810 (sets an example of how to test GmailElementReplacer)
issue #4929 (added a test helper method pgpBlockCheck for checking data in an existing pgp block)
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):