Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test (some of) GmailElementReplacer tests in mock environment #4810

Closed
rrrooommmaaa opened this issue Nov 24, 2022 · 0 comments · Fixed by #5069
Closed

Test (some of) GmailElementReplacer tests in mock environment #4810

rrrooommmaaa opened this issue Nov 24, 2022 · 0 comments · Fixed by #5069
Assignees
@rrrooommmaaa
Labels
PR Submitted Indicated that PR is already submitted for this issue
Milestone
8.5.0: Sign FES m...

Comments

@rrrooommmaaa
Copy link
Contributor

For this we would need to extend our mock gmail endpoints, like mail/u/0/#inbox/FMfcgzGrbHrBdFGBXqpFZvSkcQpKkvrM
to return a page similar to what gmail once returned

Originally posted by @rrrooommmaaa in #4807 (comment)
@tomholub tomholub added this to the Second priority milestone Dec 21, 2022
rrrooommmaaa pushed a commit that referenced this issue Feb 19, 2023
Infrastructure to test GmailElementReplacer #4810
6211ede
@rrrooommmaaa rrrooommmaaa mentioned this issue Feb 19, 2023
Merged
5 tasks
sosnovsky pushed a commit that referenced this issue Feb 24, 2023
@rrrooommmaaa
#4342 re-fetch cleartext signed message when HTML version is corrupted (
90825f5 
#4961)

* Infrastructure to test GmailElementReplacer #4810

* #4929 check pgp block in existing iframe

* extracting cleartext signed message from text/plain portion by signature

* #4929 fix

* fixed regex

* nicer test

* eslint fix

---------

Co-authored-by: Roman Shevchenko <roman@flowcrypt.com>
@rrrooommmaaa rrrooommmaaa mentioned this issue Mar 1, 2023
Merged
5 tasks
@rrrooommmaaa rrrooommmaaa self-assigned this May 18, 2023
@rrrooommmaaa rrrooommmaaa added the PR Submitted Indicated that PR is already submitted for this issue label May 18, 2023
@rrrooommmaaa rrrooommmaaa mentioned this issue May 18, 2023
Merged
5 tasks
@tomholub tomholub modified the milestones: Second priority, 8.5.0 Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrrooommmaaa rrrooommmaaa

Labels
PR Submitted Indicated that PR is already submitted for this issue
Projects
None yet
Milestone
8.5.0: Sign FES messages, various bug...
Development

Successfully merging a pull request may close this issue.

GmailElementReplacer refactoring FlowCrypt/flowcrypt-browser
2 participants
@tomholub @rrrooommmaaa