Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check usage of Axios #1390

Closed
hardillb opened this issue Dec 9, 2022 · 3 comments
Closed

Check usage of Axios #1390

hardillb opened this issue Dec 9, 2022 · 3 comments
Labels
task A piece of work that isn't necessarily tied to a specific Epic or Story.
Milestone
1.3

Comments

@hardillb
Copy link
Contributor

hardillb commented Dec 9, 2022

Description

Review #1328

in light of

axios/axios#5357

Epic/Story

No response
@hardillb hardillb added task A piece of work that isn't necessarily tied to a specific Epic or Story. priority:high High Priority labels Dec 9, 2022
@hardillb
Copy link
Contributor Author

hardillb commented Dec 9, 2022

Possible work around is to ensue that br is not in the Accepted-Encoding header

@hardillb hardillb added this to the 1.2 milestone Dec 9, 2022
@Pezmc
Copy link
Contributor

Pezmc commented Dec 9, 2022 •
edited
Loading

Given it's a Axios issue, rather than a Brotli issue, I'd propose we downgrade to 1.1.3 which does not have this issue until there's a stable release ready, rather than disabling brotli encoding. It's exactly this kind of issue which makes working with dependabot difficult!

@Pezmc Pezmc mentioned this issue Dec 9, 2022
Merged
@knolleary knolleary modified the milestones: 1.2, 1.3 Dec 23, 2022
@ZJvandeWeg ZJvandeWeg removed the priority:high High Priority label Jan 4, 2023
@knolleary
Copy link
Member

Given we have already downgraded to 1.1.3, there's nothing more to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task A piece of work that isn't necessarily tied to a specific Epic or Story.
Projects
🛠 Development
Archived in project
Milestone
1.3
Development

No branches or pull requests
4 participants
@knolleary @Pezmc @hardillb @ZJvandeWeg