Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test for kubernetes driver #2220

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Fix test for kubernetes driver #2220

merged 2 commits into from
Jun 5, 2023

Conversation

hardillb
Copy link
Contributor

@hardillb hardillb commented Jun 2, 2023

The test was looking for k8s when it should have been kubernetes

Description

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb added this to the 1.8 milestone Jun 2, 2023
@hardillb hardillb requested a review from Steve-Mcl June 2, 2023 15:32
@hardillb hardillb self-assigned this Jun 2, 2023
@joepavitt
Copy link
Contributor

Approved subject to tests passing

@Steve-Mcl
Copy link
Contributor

Approved bar the failing ppstges test. I've not looked into why they're failing, so will leave for Ben to judge.

@knolleary
Copy link
Member

We should also fix the sample config file we provide, because that says the correct value is k8s - https://github.com/flowforge/flowforge/blob/5083c22855db9a5bc8c6e108376d016d4b97ac17/etc/flowforge.yml#L34

@hardillb
Fix test for kubernetes driver
180925a 
The test was looking for `k8s` when it should have been `kubernetes`
@hardillb
Update example
42420a9
@hardillb
Copy link
Contributor Author

hardillb commented Jun 5, 2023

OK, this runs clean apart from the Postgres issue being addressed in #2226 I'm going to merge this then it's done

@hardillb hardillb merged commit 70dc4ed into main Jun 5, 2023
2 of 3 checks passed
@hardillb hardillb deleted the hardillb-patch-2 branch June 5, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steve-Mcl Steve-Mcl Steve-Mcl approved these changes

@joepavitt joepavitt joepavitt approved these changes

Assignees

@hardillb hardillb

Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hardillb @joepavitt @Steve-Mcl @knolleary