Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Error: byPipeline takes an ID not an object #2226

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

Pezmc
Copy link
Contributor

@Pezmc Pezmc commented Jun 5, 2023

Description

Seems to only fail with PostGres driver not with SQLLite

Related Issue(s)

Fixes #2223

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on flowforge/helm to update ConfigMap Template
    • Issue/PR raised on flowforge/CloudProject to update values for Staging/Production

Labels

  • Backport needed? -> add the backport label
  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb mentioned this pull request Jun 5, 2023
11 tasks
@hardillb
Copy link
Contributor

hardillb commented Jun 5, 2023

Something strange here, the Postgres test has passed, but the localfs/stub build is hung up. I would suggest stopping it and re-running. Especially as the fix is for Postgres

@Pezmc Pezmc marked this pull request as ready for review June 5, 2023 10:30
@hardillb hardillb merged commit 5ccf109 into main Jun 5, 2023
@hardillb hardillb deleted the chore-fix-postgres-tests branch June 5, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres Test Failure on Main
2 participants