Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlowETL config should always be validated when reading from a config file #1375

Closed
maxalbert opened this issue Oct 9, 2019 · 0 comments · Fixed by #1380
Closed

FlowETL config should always be validated when reading from a config file #1375

maxalbert opened this issue Oct 9, 2019 · 0 comments · Fixed by #1380
Labels
bug Something isn't working FlowETL

Comments

@maxalbert
Copy link
Contributor

Currently the FlowETL config is validated (and default values filled in) in dags/etl.py after it is read from the config.yml file.

However, get_config_from_file () is also used in another place without subsequent calls to validate_config() and fill_config_default_values(). This can cause strange errors in production if the config file isn't valid or is missing default values.

Therefore those subsequent validation/filling steps should happen in get_config_from_file() directly.

@maxalbert maxalbert added bug Something isn't working FlowETL labels Oct 9, 2019
@mergify mergify bot closed this as completed in #1380 Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working FlowETL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant