Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Removes miasma and gibs diseases #3497

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#2675
Original PR: tgstation/tgstation#83455

About The Pull Request

Removes miasma generating random viruses (in two locations for some reason)
Also removes diseases being generated by gibs, which is responsible for a lot of disease spam

Why It's Good For The Game

New diseases are spread through events and virology (and some other minor sources). Miasma and gibs are a source of random viruses that dilutes player response to diseases. It's frankly exhausting curing the disease outbreak, just to see 10 others pop-up. Hopefully we can reduce the madness a bit and place more focus on individual diseases

Changelog

馃啈 Time-Green
del: Miasma and gibs no longer generates random diseases
/:cl:

Something like lung rot could be cool though, but out of scope for the current PR

* Removes miasma and gibs diseases (#83455)

## About The Pull Request
Removes miasma generating random viruses (in two locations for some
reason)
Also removes diseases being generated by gibs, which is responsible for
a lot of disease spam

## Why It's Good For The Game
New diseases are spread through events and virology (and some other
minor sources). Miasma and gibs are a source of random viruses that
dilutes player response to diseases. It's frankly exhausting curing the
disease outbreak, just to see 10 others pop-up. Hopefully we can reduce
the madness a bit and place more focus on individual diseases

## Changelog
:cl:
del: Miasma and gibs no longer generates random diseases
/:cl:

Something like lung rot could be cool though, but out of scope for the
current PR

* Removes miasma and gibs diseases

---------

Co-authored-by: Time-Green <7501474+Time-Green@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>
@Iajret Iajret merged commit 1e02820 into master May 28, 2024
27 checks passed
@Iajret Iajret deleted the upstream-mirror-2675 branch May 28, 2024 07:28
AnywayFarus added a commit that referenced this pull request May 28, 2024
Iajret pushed a commit that referenced this pull request Jul 4, 2024
* Update blood filter [NO GBP] (#84535)

## About The Pull Request

Updates the blood filter sound change made in
tgstation/tgstation#84431


https://github.com/tgstation/tgstation/assets/83487515/abe88a4c-2c48-46af-8ea9-f6c0f2da7259

## Why It's Good For The Game

The sound in the first PR is clipping when used as a surgery success
sound. Rounds the removal amount so it doesn't leave small decimal point
values left in the blood.

## Changelog

:cl: LT3
sound: Changed blood filter cycle sound
/:cl:

* Update blood filter [NO GBP]

---------

Co-authored-by: lessthanthree <83487515+lessthnthree@users.noreply.github.com>
Co-authored-by: NovaBot13 <novasector13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants