Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes miasma and gibs diseases #83455

Merged
merged 2 commits into from
May 26, 2024

Conversation

Time-Green
Copy link
Contributor

@Time-Green Time-Green commented May 25, 2024

About The Pull Request

Removes miasma generating random viruses (in two locations for some reason)
Also removes diseases being generated by gibs, which is responsible for a lot of disease spam

Why It's Good For The Game

New diseases are spread through events and virology (and some other minor sources). Miasma and gibs are a source of random viruses that dilutes player response to diseases. It's frankly exhausting curing the disease outbreak, just to see 10 others pop-up. Hopefully we can reduce the madness a bit and place more focus on individual diseases

Changelog

馃啈
del: Miasma and gibs no longer generates random diseases
/:cl:

Something like lung rot could be cool though, but out of scope for the current PR

@tgstation-server tgstation-server added the Removal This was too fun, too fun! I'm turning this feature around label May 25, 2024
@the-orange-cow
Copy link
Contributor

the-orange-cow commented May 25, 2024

Not necessarily opposed to this, but isn't virus generation the only thing miasma does? I'm not an atmos expert, but my understanding is that it's mostly inert. The gas ought to have at least some purpose. Would it be possible to replace virus generation with something else instead of just removing virus generation?

Edit: No one sane will miss gibs disease removal.

@Time-Green
Copy link
Contributor Author

Not necessarily opposed to this, but isn't virus generation the only thing miasma does? I'm not an atmos expert, but my understanding is that it's mostly inert. The gas ought to have at least some purpose. Would it be possible to replace virus generation with something else instead of just removing virus generation?

It adds mood and disgust as well

@Jacquerel
Copy link
Contributor

Is there an avenue for simply replacing these with the floor food viruses as a sort of shared "common cold" pool?
They're annoying at worst but still something you will want to get fixed, don't cause widespread disruption, and have predictable cures.

@Time-Green
Copy link
Contributor Author

Is there an avenue for simply replacing these with the floor food viruses as a sort of shared "common cold" pool? They're annoying at worst but still something you will want to get fixed, don't cause widespread disruption, and have predictable cures.

I'd like to add rimworld lungrot later down the line as a replacement

@OverwatchVoice
Copy link
Contributor

Sounds like you were fighting the disease, not the symptom and now you're mad about it.
The metaphorical disease, I mean. Not the actual one.

@Jacquerel
Copy link
Contributor

Is there an avenue for simply replacing these with the floor food viruses as a sort of shared "common cold" pool? They're annoying at worst but still something you will want to get fixed, don't cause widespread disruption, and have predictable cures.

I'd like to add rimworld lungrot later down the line as a replacement

I mean if you're going to reimplement the disease application later it might still make sense to have it apply specific diseases now and swap out which ones once your new one is done 馃槄

@Time-Green Time-Green changed the title Removes miasma diseases Removes miasma and gibs diseases May 25, 2024
@DaCoolBoss
Copy link
Contributor

This makes miasma really pointless, mood reduction is irrelevant really. Not a fan, this gas should be hazardous on some level (preferably a low threat one).

Notably, this gas is removed by firing a flamethrower down corridors when it's present. It allows Atmos techs to turn a permanent issue (let's ignore the fact that they can just set scrubbers to filter miasma for a second) into a temporary problem of increased temp and CO2 production. If miasma doesn't really do anything dangerous we discourage nonantagonistic atmos techs from doing this. I think the flamethrower solution is cool enough that we should make sure it stays a viable option.

@Higgin
Copy link
Contributor

Higgin commented May 25, 2024

One thing that could be done here is just making viruses generated by these sources have much lower severity or even a static set of low-severity symptoms. Putting coughing/sneezing + fever/chills on them, some combination of one of each, would make low-severity viruses that are still a reason to keep the station's floor and air clean.

Nobody really does the shit I used to do with these - use them as a base to make improvised advanced viruses - and if we're nerfing advanced viruses across the board or giving people more ways to deal with them, we can make these sources more of a meaningful but not overly disruptive annoyance on their own rather than take away the whole interaction.

@MrMelbert
Copy link
Contributor

What's the downside for walking around in horrible muck barefoot now?

@Time-Green
Copy link
Contributor Author

What's the downside for walking around in horrible muck barefoot now?

You don't get the troll the rest of the crew by having 30 diseases?

@LSommers
Copy link

Just make it non-communicable diseases to directly punish John Greyshit His Incredible Monkey Exploder Machine.

@MrMelbert
Copy link
Contributor

You don't get the troll the rest of the crew by having 30 diseases?

Removes janitor contents 馃憥

@CCC23
Copy link
Contributor

CCC23 commented May 26, 2024

its so joever we can no longer make 30000 million death diseases at a time by flooding the station with fart gas

@Dawnseer
Copy link
Contributor

Have you tried getting a janitor to do their thing instead? This seems a bit heavy handed for what is essentially letting the station fall apart but wanting to do so without consequence.

@jlsnow301 jlsnow301 merged commit b872baf into tgstation:master May 26, 2024
21 checks passed
comfyorange added a commit that referenced this pull request May 26, 2024
@Time-Green Time-Green deleted the remove-miasma-diseases branch May 26, 2024 20:22
@Time-Green
Copy link
Contributor Author

Damn now I gotta actually add miasma and gibs content

Chowder-McArthor pushed a commit to Chowder-McArthor/desertbus13 that referenced this pull request Jun 6, 2024
## About The Pull Request
Removes miasma generating random viruses (in two locations for some
reason)
Also removes diseases being generated by gibs, which is responsible for
a lot of disease spam

## Why It's Good For The Game
New diseases are spread through events and virology (and some other
minor sources). Miasma and gibs are a source of random viruses that
dilutes player response to diseases. It's frankly exhausting curing the
disease outbreak, just to see 10 others pop-up. Hopefully we can reduce
the madness a bit and place more focus on individual diseases

## Changelog
:cl:
del: Miasma and gibs no longer generates random diseases
/:cl:

Something like lung rot could be cool though, but out of scope for the
current PR
Chowder-McArthor pushed a commit to Chowder-McArthor/desertbus13 that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Removal This was too fun, too fun! I'm turning this feature around
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet