[MIRROR] Removes miasma and gibs diseases #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request Removes miasma generating random viruses (in two locations for some reason) Also removes diseases being generated by gibs, which is responsible for a lot of disease spam ## Why It's Good For The Game New diseases are spread through events and virology (and some other minor sources). Miasma and gibs are a source of random viruses that dilutes player response to diseases. It's frankly exhausting curing the disease outbreak, just to see 10 others pop-up. Hopefully we can reduce the madness a bit and place more focus on individual diseases ## Changelog :cl: del: Miasma and gibs no longer generates random diseases /:cl: Something like lung rot could be cool though, but out of scope for the current PR
NovaBot13
added
the
Removal
| @@ -45,8 +45,6 @@ | |||
| RegisterSignal(parent, COMSIG_GLASS_DRANK, PROC_REF(try_infect_drink)) | |||
| if(isorgan(parent)) | |||
| RegisterSignal(parent, COMSIG_ORGAN_IMPLANTED, PROC_REF(on_organ_insertion)) | |||
| else if(istype(parent, /obj/effect/decal/cleanable/blood/gibs)) | |||
| RegisterSignal(parent, COMSIG_GIBS_STREAK, PROC_REF(try_infect_streak)) | |||
There was a problem hiding this comment.
try_infect_streak is just dead code, now
| @@ -111,16 +111,13 @@ | |||
| drydesc = "They look bloody and gruesome while some terrible smell fills the air." | |||
| decal_reagent = /datum/reagent/consumable/liquidgibs | |||
| reagent_amount = 5 | |||
| ///Information about the diseases our streaking spawns | |||
| var/list/streak_diseases | |||
|
|
|||
| /obj/effect/decal/cleanable/blood/gibs/Initialize(mapload, list/datum/disease/diseases) | |||
| . = ..() | |||
| AddElement(/datum/element/squish_sound) | |||
| RegisterSignal(src, COMSIG_MOVABLE_PIPE_EJECTING, PROC_REF(on_pipe_eject)) | |||
|
|
|||
| /obj/effect/decal/cleanable/blood/gibs/Destroy() | |||
There was a problem hiding this comment.
no reason for this to exist anymore
There was a problem hiding this comment.
The gibs/destroy() proc, I mean. It's just a return ..() with nothing else.
| @@ -170,7 +166,7 @@ | |||
| SIGNAL_HANDLER | |||
| if(NeverShouldHaveComeHere(loc)) | |||
| return | |||
| new /obj/effect/decal/cleanable/blood/splatter(loc, streak_diseases) | |||
There was a problem hiding this comment.
seems like this wasn't fully cleaned up
FlufflesTheDog
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: tgstation/tgstation#83455
About The Pull Request
Removes miasma generating random viruses (in two locations for some reason)
Also removes diseases being generated by gibs, which is responsible for a lot of disease spam
Why It's Good For The Game
New diseases are spread through events and virology (and some other minor sources). Miasma and gibs are a source of random viruses that dilutes player response to diseases. It's frankly exhausting curing the disease outbreak, just to see 10 others pop-up. Hopefully we can reduce the madness a bit and place more focus on individual diseases
Changelog
馃啈
del: Miasma and gibs no longer generates random diseases
/:cl:
Something like lung rot could be cool though, but out of scope for the current PR