Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence compiler warnings on macOS #1047

Closed
wants to merge 3 commits into from
Closed

Silence compiler warnings on macOS #1047

wants to merge 3 commits into from

Conversation

bradhowes
Copy link
Contributor

  • Don't compare unsigned int values as NULL
  • Hoist variable declarations to top of function
  • Migrate from deprecated identifier

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, thanks. Pls. have a look at the failing build on Mac 10.15. And two nit-picks below.

src/drivers/fluid_coreaudio.c Outdated Show resolved Hide resolved
src/drivers/fluid_coremidi.c Outdated Show resolved Hide resolved
@bradhowes
Copy link
Contributor Author

bradhowes commented Feb 19, 2022

@derselbst Thanks for the reviews. I checked out the failures below and they all involve pipeline setup failures:

  • Timeouts fetching mingw-64 (I was able to manually fetch but it is slow).
  • Chocolatey failure due to missing checksums for the pkgconfiglite package -- looks like it can be fixed with -allow-empty-checksums flag or manually calculate a checksum and pass it to the Chocolatey command line.

Copy link
Member

@derselbst derselbst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the Windows checks are a bit unstable. The Mac builds are green now, which matter most. Thank you! If you want you can rebase your changes against the 2.2.x branch. Otherwise I would merge it manually by tomorrow or so, so we can ship this with fluidsynth 2.2.6.

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derselbst
Copy link
Member

Cherry-picked to 2.2.x and merged back to master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants