-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Silence compiler warnings on macOS #1047
Conversation
bradhowes
commented
Feb 18, 2022
- Don't compare unsigned int values as NULL
- Hoist variable declarations to top of function
- Migrate from deprecated identifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM in general, thanks. Pls. have a look at the failing build on Mac 10.15. And two nit-picks below.
@derselbst Thanks for the reviews. I checked out the failures below and they all involve pipeline setup failures:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the Windows checks are a bit unstable. The Mac builds are green now, which matter most. Thank you! If you want you can rebase your changes against the 2.2.x
branch. Otherwise I would merge it manually by tomorrow or so, so we can ship this with fluidsynth 2.2.6.
Kudos, SonarCloud Quality Gate passed!
|
Cherry-picked to 2.2.x and merged back to master. Thanks! |