Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk.createHttpResponse should have options to manage caches #401

Closed
LoicPoullain opened this issue Mar 28, 2019 · 1 comment
Closed

Disk.createHttpResponse should have options to manage caches #401

LoicPoullain opened this issue Mar 28, 2019 · 1 comment
Labels
feature request

Comments

@LoicPoullain
Copy link
Member

LoicPoullain commented Mar 28, 2019 •
edited
Loading

Issue

Currently the method createHttpResponseFile of the Disk service does not have headers to manage the cache on the client.

Possible solution

Take a look at the headers Etag, Cache-Control, Expires, Date, Last-Modified, Vary and see what can be done.
@LoicPoullain LoicPoullain changed the title [Dowload files] createHttpResponseFile should have options to manage caches Disk.createHttpResponse should have options to manage caches Feb 12, 2020
This was referenced May 14, 2021
Merged
Merged
@LoicPoullain
Copy link
Member Author

Resolved in v2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
Issue tracking
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LoicPoullain