Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of option to change payload size #596

Closed
qubiack opened this issue Dec 15, 2019 · 4 comments
Closed

Lack of option to change payload size #596

qubiack opened this issue Dec 15, 2019 · 4 comments

Comments

@qubiack
Copy link

qubiack commented Dec 15, 2019

It's impossible to change a payload data size.

Now request body can have only 100kb but if you want to send more you can't change the acceptable payload size using standard Express method.

async function main() {
    const app = createApp(AppController);
    app.use(bodyParser.json({limit: '50mb'}));
    app.use(bodyParser.raw({limit: '50mb'}));
    app.use(bodyParser.urlencoded({limit: '50mb', extended: true}));

    const httpServer = http.createServer(app);
    dotenv.config();

    const port = Config.get('PORT', process.env.PORT || 4000);
    httpServer.listen(port, () => {
        console.log(`Listening on port ${port}...`);
    });
    httpServer.timeout = 10000000;
}
This was referenced Dec 16, 2019
@LoicPoullain
Copy link
Member

Hi @qubiack. Thank you for pointing this out. A PR is on its way. The feature will be released with version 1.4.0.

@qubiack
Copy link
Author

qubiack commented Dec 16, 2019

@LoicPoullain do you have a plan of release? I need to know if I can wait on this or I should quick migrate my project.

@LoicPoullain
Copy link
Member

@qubiack it should be released at the beginning of January. I'm taking two weeks of vacations in the next few days.

@qubiack
Copy link
Author

qubiack commented Dec 17, 2019

thanks for the information. Have a nice vacation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants