Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Ajv configuration #633

Closed
kylehalleman opened this issue Feb 14, 2020 · 3 comments
Closed

Extending Ajv configuration #633

kylehalleman opened this issue Feb 14, 2020 · 3 comments

Comments

@kylehalleman
Copy link

I noticed in #343 there was a discussion about adding a specific option to the Ajv instance. Is there a reason for not opening up all of the Ajv options to the user? I find myself wanting to set allErrors to true so I can get all the errors and then display them under each input, so a user can correct all their errors, instead of correcting one, submitting, finding they have another error they didn't know about.

Wondering what can be done to allow some flexibility here (outside of creating my own Ajv instance and using that instead).

Thanks. Love the project!

@LoicPoullain
Copy link
Member

Hi @kylehalleman

Is there a reason for not opening up all of the Ajv options to the user?

All Ajv options could be supported I guess. But it would require some extra work to test all of the options and I'm not sure if it's necessary (at least, for all AJV options). So I'm adding options as they are requested in the Github issues.

I opened a PR so that the next release has the allErrors option 👍

@LoicPoullain LoicPoullain mentioned this issue Feb 17, 2020
5 tasks
@kylehalleman
Copy link
Author

That makes sense why all options aren't available, thanks for explaining and for adding the allErrors option. Keep up the great work!

@LoicPoullain
Copy link
Member

Version 1.7 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants