Skip to content

Commit

Permalink
Merge pull request #417 from KishanViramgama/master
Browse files Browse the repository at this point in the history
Update jQuery 3.4.1
  • Loading branch information
Mahavir Jain committed Jan 9, 2020
2 parents 2a3b4d5 + 4138c1d commit 2ef9269
Show file tree
Hide file tree
Showing 8 changed files with 24 additions and 18 deletions.
4 changes: 0 additions & 4 deletions folioreader/src/main/assets/js/jquery-3.1.1.min.js

This file was deleted.

2 changes: 2 additions & 0 deletions folioreader/src/main/assets/js/jquery-3.4.1.min.js

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static String getHtmlContent(Context context, String htmlContent, Config
"file:///android_asset/js/jsface.min.js") + "\n";

jsPath = jsPath + String.format(context.getString(R.string.script_tag),
"file:///android_asset/js/jquery-3.1.1.min.js") + "\n";
"file:///android_asset/js/jquery-3.4.1.min.js") + "\n";

jsPath = jsPath + String.format(context.getString(R.string.script_tag),
"file:///android_asset/js/rangy-core.js") + "\n";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class MediaControllerFragment : BottomSheetDialogFragment() {

if (event.action == MotionEvent.ACTION_DOWN) {
Log.v(LOG_TAG, "-> onTouch -> touch_outside -> ${getView()}")
dialog.hide()
dialog!!.hide()
visible = false
return@setOnTouchListener true
}
Expand Down Expand Up @@ -115,10 +115,10 @@ class MediaControllerFragment : BottomSheetDialogFragment() {
super.onStart()
Log.v(LOG_TAG, "-> onStart")

dialog.setOnKeyListener { _, keyCode, event ->
dialog!!.setOnKeyListener { _, keyCode, event ->
if (event.action == MotionEvent.ACTION_UP && keyCode == KeyEvent.KEYCODE_BACK) {
Log.v(LOG_TAG, "-> Back button pressed")
dialog.hide()
dialog!!.hide()
visible = false
return@setOnKeyListener true
}
Expand All @@ -129,7 +129,7 @@ class MediaControllerFragment : BottomSheetDialogFragment() {
bottomSheetBehavior.state = BottomSheetBehavior.STATE_EXPANDED

if (!visible)
dialog.hide()
dialog!!.hide()
}

override fun onSaveInstanceState(outState: Bundle) {
Expand All @@ -155,7 +155,7 @@ class MediaControllerFragment : BottomSheetDialogFragment() {
visible = true
if (isAdded) {
//Log.v(LOG_TAG, "-> Is already added")
dialog.show()
dialog!!.show()
} else {
//Log.v(LOG_TAG, "-> Not added")
show(fragmentManager, MediaControllerFragment.LOG_TAG)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ class FolioWebView : WebView {
val bundle = Bundle()
bundle.putString(Constants.SELECTED_WORD, selectedText?.trim())
dictionaryFragment.arguments = bundle
dictionaryFragment.show(parentFragment.fragmentManager, DictionaryFragment::class.java.name)
dictionaryFragment.show(parentFragment.fragmentManager!!, DictionaryFragment::class.java.name)
}

private fun onHighlightColorItemsClicked(style: HighlightStyle, isAlreadyCreated: Boolean) {
Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
12 changes: 10 additions & 2 deletions sample/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ dependencies {
implementation "androidx.appcompat:appcompat:$versions.appcompat"
implementation "androidx.constraintlayout:constraintlayout:$versions.constraintLayout"
testImplementation 'junit:junit:4.12'
androidTestImplementation "androidx.test.ext:junit:1.0.0"
androidTestImplementation 'androidx.test.espresso:espresso-core:3.1.0'
androidTestImplementation "androidx.test.ext:junit:1.1.1"
androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'

implementation project(':folioreader')
//implementation "com.folioreader:folioreader:$versions.folioreaderSdk"
Expand All @@ -63,4 +63,12 @@ dependencies {
implementation "com.fasterxml.jackson.core:jackson-annotations:$versions.jackson"
implementation "com.fasterxml.jackson.core:jackson-databind:$versions.jackson"
implementation "com.fasterxml.jackson.module:jackson-module-kotlin:$versions.jackson"

//progressBar error solve
configurations.matching { it.name == '_internal_aapt2_binary' }.all { config ->
config.resolutionStrategy.eachDependency { details ->
details.useVersion("3.3.2-5309881")
}
}

}
8 changes: 4 additions & 4 deletions versions.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,18 @@ versions.androidMinSdk = 21
versions.androidCompileSdk = 28
versions.androidTargetSdk = 28

versions.androidGradlePlugin = "3.2.1"
versions.androidGradlePlugin = "3.5.3"
versions.kotlin = "1.3.11"

versions.appcompat = "1.0.2"
versions.appcompat = "1.1.0"
versions.constraintLayout = "1.1.3"
versions.recyclerview = "1.0.0"
versions.recyclerview = "1.1.0"
versions.material = "1.0.0"

versions.retrofit = "2.5.0"
versions.jackson = "2.9.7"
versions.gson = "2.8.5"

versions.lifecycle = "2.0.0"
versions.lifecycle = "2.1.0"

ext.versions = versions

0 comments on commit 2ef9269

Please sign in to comment.