Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another version that can be toggled via CSS-class #14

Closed
mkg20001 opened this issue Sep 21, 2019 · 3 comments
Closed

Add another version that can be toggled via CSS-class #14

mkg20001 opened this issue Sep 21, 2019 · 3 comments

Comments

@mkg20001
Copy link
Contributor

It would be really cool to have another version that has all classes toggled through a main class on the body tag called dark

So a page would load both stylesheets and then the dark class could be added to the body tag to toggle the darkmode

@Carl-Hugo
Copy link
Member

That's a good idea.

Without any code analysis, I think that it could be fairly easy to accomplish.

Feel free to contribute the update; otherwise, I'll do it when I get the chance.

Note to self: creating a premade "dark/light" toggle button that switches from dark to light theme could be nice (in its own npm package/git repo).

@mkg20001
Copy link
Contributor Author

mkg20001 commented Sep 25, 2019

Feel free to contribute the update; otherwise, I'll do it when I get the chance.

Right now I have too much on my plate so I'd leave that to you ^^

@mkg20001
Copy link
Contributor Author

I've cooked up something half finished #15
But it seems to be broken: Light theme works, dark theme.. is light

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants