Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows disk drives in the normalization algorithm #16

Open
ForNeVeR opened this issue Apr 21, 2024 · 0 comments
Open

Support Windows disk drives in the normalization algorithm #16

ForNeVeR opened this issue Apr 21, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Owner

ForNeVeR commented Apr 21, 2024

Currently, our normalization algorithm doesn't support the Windows disk drives at all. We should consider the disk drive (if present) to be ignored when normalizing path: it should be normalized regardless of the drive letter and its presence.

For example, consider this set of test cases:

    [InlineData("C:.", "C:")]
    [InlineData("C:./foo", "C:foo")]
    [InlineData("C:..", "C:..")]
    [InlineData("C:/..", "C:/..")]
    public void WindowsSpecificDotFoldersAreTraversed(string input, string expected)

We should support that and re-enable the corresponding test.

See TODO[#16] in the code when dealing with this issue.

@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant