Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement and check the behavior to calculate parents from exclusively-relative paths (., ..) #18

Closed
ForNeVeR opened this issue Apr 21, 2024 · 1 comment · Fixed by #83
Closed

Implement and check the behavior to calculate parents from exclusively-relative paths (., ..) #18

ForNeVeR opened this issue Apr 21, 2024 · 1 comment · Fixed by #83
Assignees
@ForNeVeR
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ForNeVeR
Copy link
Owner

Currently, new LocalPath(".").Parent (the same for paths like .. or ../..) is not defined: I'm not sure what it should be.

We need to see how other libraries define this path's parent (I lean towards null) and implement the same logic.
@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 21, 2024
ForNeVeR added a commit that referenced this issue Apr 21, 2024
@ForNeVeR
(#16, #17, #18, #19, #20) Process the TODO comments
6d8bf5f
Kataane added a commit to Kataane/TruePath that referenced this issue Jul 20, 2024
@Kataane
ForNeVeR#18 implement behavior to calculate parents from exclusively-…
827e82b 
…relative paths
@ForNeVeR ForNeVeR mentioned this issue Aug 11, 2024
Merged
@ForNeVeR
Copy link
Owner Author

After some work and discussion done in scope of #83, my current decision is that generally, (path1 / path2).Parent should yield the same result (if any) as path1 / path2.Parent.

Meaning new LocalPath(".").Parent should be .., and e.g. new LocalPath("../..").Parent should be ../../...

IIRC there's still a weird corner case in how we handle /.. absolute path (it could break the invariant); I am planning to handle that separately.

@ForNeVeR ForNeVeR self-assigned this Sep 22, 2024
@ForNeVeR ForNeVeR removed the help wanted Extra attention is needed label Sep 22, 2024
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) LocalPath, AbsolutePath: migrate to the new logic for P…
74560fc 
…arent calculation
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) IPath.Parent: document the current solution
ee6a6f1
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) PathStrings: drop a method that's no longer used
9826e32
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) LocalPath: more tests for strange cases
4a076bc
ForNeVeR pushed a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@Kataane @ForNeVeR
ForNeVeR#18 implement behavior to calculate parents from exclusively-…
77a1ee6 
…relative paths
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) LocalPath, AbsolutePath: migrate to the new logic for P…
0d75cad 
…arent calculation
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) IPath.Parent: document the current solution
edb444f
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) PathStrings: drop a method that's no longer used
4712d33
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) LocalPath: more tests for strange cases
63f8440
ForNeVeR added a commit to Kataane/TruePath that referenced this issue Sep 22, 2024
@ForNeVeR
(ForNeVeR#18) Docs: update the acknowledgement
a6c69e8
ForNeVeR pushed a commit that referenced this issue Sep 22, 2024
@Kataane @ForNeVeR
#18 implement behavior to calculate parents from exclusively-relative…
95e39d3 
… paths
ForNeVeR added a commit that referenced this issue Sep 22, 2024
@ForNeVeR
(#18) LocalPath, AbsolutePath: migrate to the new logic for Parent ca…
0d425ae 
…lculation
ForNeVeR added a commit that referenced this issue Sep 22, 2024
@ForNeVeR
(#18) IPath.Parent: document the current solution
2fd0bd4
ForNeVeR added a commit that referenced this issue Sep 22, 2024
@ForNeVeR
(#18) PathStrings: drop a method that's no longer used
ab4e016
ForNeVeR added a commit that referenced this issue Sep 22, 2024
@ForNeVeR
(#18) LocalPath: more tests for strange cases
8a677f4
ForNeVeR added a commit that referenced this issue Sep 22, 2024
@ForNeVeR
(#18) Docs: update the acknowledgement
5f911af
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ForNeVeR ForNeVeR

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#18 implement behavior to calculate parents from exclusively-relative paths Kataane/TruePath
1 participant
@ForNeVeR