Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations and optimize path normalization #19

Closed
ForNeVeR opened this issue Apr 21, 2024 · 0 comments · Fixed by #44
Closed

Reduce allocations and optimize path normalization #19

ForNeVeR opened this issue Apr 21, 2024 · 0 comments · Fixed by #44
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ForNeVeR
Copy link
Owner

Current implementation of PathStrings::Normalize is far from perfect:

  • it allocates quite a bit of heap memory
  • it traverses the input (and its transformations) for three times (see the three loops in the code)

I believe it should be possible to do a bit better, without losing any of the current features.
@ForNeVeR ForNeVeR added enhancement New feature or request help wanted Extra attention is needed labels Apr 21, 2024
ForNeVeR added a commit that referenced this issue Apr 21, 2024
@ForNeVeR
(#16, #17, #18, #19, #20) Process the TODO comments
6d8bf5f
ForNeVeR added a commit that referenced this issue May 2, 2024
@ForNeVeR
(#19) Introduce benchmarks
ab8cdc7
ForNeVeR added a commit that referenced this issue May 2, 2024
@ForNeVeR
(#19) Benchmarks: more variants and results
a29ac69
ForNeVeR added a commit that referenced this issue May 2, 2024
@ForNeVeR
(#19) PathStrings: fixed length cutoff, return array to pool after us…
b4f0b8a 
…e only
@ForNeVeR ForNeVeR mentioned this issue May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TruePath: optimize path normalization
1 participant
@ForNeVeR