Reliably resolve parent directory for batch files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
%~dp0 is not reliable. If the batch file invocation is quoted and invoked without a path, %~dp0 is set to $PWD instead of the batch file's parent directory. Fixes npm#10
|
Can you update this pull request so it can be more easily merged? |
|
This definitely needs an example use case so I can tell what it's actually doing. If I'm correctly understanding the issue described, the approach in this patch is going to fail as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%~dp0is not reliable. If the batch file invocation is quoted and invoked without a path,%~dp0is set to $PWD instead of the batch file's parent directory.Fixes #10