Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon request: fa-basketball #87

Closed
iamcryptoki opened this issue Jun 11, 2018 · 4 comments
Closed

Icon request: fa-basketball #87

iamcryptoki opened this issue Jun 11, 2018 · 4 comments
Labels
icon-request New icon request

Comments

@iamcryptoki
Copy link

Hi,

I think it would be fantastic to have an icon for "Basketball".

Example :

46341-basketball-ball-outline

More examples here.

@xuv xuv added the icon-request New icon request label Jun 11, 2018
@tessus
Copy link
Member

tessus commented Jun 11, 2018

Can you please describe a use case for this icon?

@iamcryptoki
Copy link
Author

Can you please describe a use case for the existing fa-futbol-o icon?

soccer-icon

@tessus
Copy link
Member

tessus commented Jun 12, 2018

No, I can't because I didn't add this icon.

However, if you want an icon to be added, you should add a use case. If you don't have one, you don't need the icon. Adding icons makes the font bigger. So, if there's no use case why should it be added in the first place?

@xuv I think it is time to add a template for icon requests. I have a few in a test repo. github also allows different templates for different purposes. let's talk about this offline.

@xuv
Copy link
Member

xuv commented Jun 12, 2018

Hey. I think both of your questions are legitimate. Indeed, from @iamcryptoki's point of view, I understand the request and I also agree that if there is a Futbal icon, there could be a basketball one or a baseball one. But if you, @iamcryptoki, don't have an immediate use for it at the moment that you can share with us, then it's not probably going to be on our priority list.

On another hand, I also appreciate that you linked to a usable icon. There is probably some work to do on it to get the line width in balance with the rest of the line width used in the other icons. But it's a good proposition to start from.

As @tessus suggested also, having a template for icon requests will help in the future ask for these questions from the start.

@iamcryptoki iamcryptoki closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon-request New icon request
Projects
None yet
Development

No branches or pull requests

3 participants