Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Use exenv to bail on browser-specifics #149

Merged
merged 2 commits into from
May 15, 2015
Merged

Use exenv to bail on browser-specifics #149

merged 2 commits into from
May 15, 2015

Conversation

ianobermiller
Copy link
Contributor

While rendering on the server, we cannot access browser specific features. Use exenv to check if the browser environment is available.

Required for #141.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.71%) to 99.29% when pulling ab7a0d5 on execution-environment into f28d28e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.71%) to 99.29% when pulling e6a4cf4 on execution-environment into f28d28e on master.

@alexlande
Copy link
Contributor

Nice 👍

@ianobermiller ianobermiller force-pushed the execution-environment branch 2 times, most recently from b506f3a to a8e6b13 Compare May 15, 2015 12:56
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b506f3a on execution-environment into 581df45 on master.

@ianobermiller
Use exenv to bail on browser-specifics
ac7afad 
While rendering on the server, we cannot access browser specific
features. Use `exenv` to check if the browser environment is available.
@ianobermiller
Fix prefix on server with css style
88cf2fc
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a8e6b13 on execution-environment into 581df45 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 88cf2fc on execution-environment into 581df45 on master.

@ianobermiller ianobermiller mentioned this pull request May 15, 2015
Closed
ianobermiller added a commit that referenced this pull request May 15, 2015
@ianobermiller
Merge pull request #149 from FormidableLabs/execution-environment
823b6fd 
Use exenv to bail on browser-specifics
@ianobermiller ianobermiller merged commit 823b6fd into master May 15, 2015
@ianobermiller ianobermiller deleted the execution-environment branch May 15, 2015 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianobermiller @coveralls @alexlande