This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
extending prototype functions in order to fix hot loader #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the setting up of the initial
this.state._radiumStyleState
because there's no way to reconcile the differences between ES6 classes and React.createClass without creating a wrapping constructor that kills hot loading. It also removes the tests for that behaviour because it doesn't actually seem to negatively affect the behaviour.You can see that this branch works with hot loader by cloning my fork of
react-hot-boilerplate
- https://github.com/bobbyrenwick/react-hot-boilerplate/tree/test-radium-hoc.The only thing I'm not too sure about is that I've deleted some Flow annotations and I'm not sure what sort of effects that will have as I haven't had much time to play around with it! @ianobermiller is there anything Flow related that needs to be done?
Fixes #219