This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
fixing React Hot Loader by copying methods across to top level prototype #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:D Thanks @bobbyrenwick |
ianobermiller
added a commit
that referenced
this pull request
Jul 13, 2015
fixing React Hot Loader by copying methods across to top level prototype
This was referenced Jul 13, 2015
AnSavvides
pushed a commit
to AnSavvides/radium
that referenced
this pull request
Aug 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's hope second time around I've actually solved this...
This is solution 2 from @gaearon's suggestions. #252 needs to be closed because I couldn't find any way to resolve facebook/react#3316 and the differences between setting the state in ES6 classes vs
React.createClasswithout doing something similar to the current master branch.Given that the code was heading back in that direction, I opted for just exposing all methods on the Component's prototype that haven't already been overwritten by the subclass. I liked the suggestion of only doing this in dev too, so I've sorted that too.
Example of it here - https://github.com/bobbyrenwick/react-hot-boilerplate/tree/test-radium-hoc-2