Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Remove printStyles feature #479

Merged
merged 2 commits into from
Jan 5, 2016
Merged

Remove printStyles feature #479

merged 2 commits into from
Jan 5, 2016

Conversation

ianobermiller
Copy link
Contributor

No longer needed, since media query styles are now rendered as CSS
anyway.

cc @bobbyrenwick

@bobbyrenwick
Copy link
Contributor

I'm a little concerned that after this there's no tests ensuring that print media query styles get extracted into the top level isRoot or soon to be (<StyleRoot>) component. How about adding a print media query test like the one added in cb58b5d?

@bobbyrenwick
Copy link
Contributor

I should also have said that the fact that SSR and print styles now have the same implementation is great. I'm glad to see this go and the API surface area become smaller!

@ianobermiller
Copy link
Contributor Author

Yes I meant to add a test, thanks for the reminder.
On Sun, Jan 3, 2016 at 2:00 AM Bob Renwick notifications@github.com wrote:

I should also have said that the fact that SSR and print styles now have
the same implementation is great. I'm glad to see this go and the API
surface area become smaller!


Reply to this email directly or view it on GitHub
#479 (comment)
.

No longer needed, since media query styles are now rendered as CSS
anyway.
ianobermiller added a commit that referenced this pull request Jan 5, 2016
@ianobermiller ianobermiller merged commit 09355c0 into master Jan 5, 2016
@alexlande alexlande deleted the remove-print-styles branch April 22, 2016 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants