Handle multiple animationName props #909

jaredbrookswhite · 2017-07-13T00:02:43Z

Method to handle #675.

coveralls · 2017-07-13T00:09:43Z

Coverage increased (+0.04%) to 94.016% when pulling f4a7e7d on jaredbrookswhite:feature-multiple-animationName-props into 42dba09 on FormidableLabs:master.

kylecesmat · 2018-08-22T01:23:22Z

@jaredbrookswhite could you refresh this PR? We'd like to get it merged :)

looks like it's failing on a prettier task.

/home/travis/build/FormidableLabs/radium/examples/app.jsx
  84:19  error  Follow `prettier` formatting (expected '\n' but found 'm')  prettier/prettier
✖ 1 problem (1 error, 0 warnings)

kylecesmat

Thank you so much for the great test coverages! This PR looks great, just a few pieces of feedback

kylecesmat · 2018-08-22T01:28:57Z

src/plugins/keyframes-plugin.js

+      if (
+        key === 'animationName' &&
+        value &&
+        (value.__radiumKeyframes || Array.isArray(value))


Could we do this check above the if block?

let value = style[key]; const isKeyframeArray = Array.isArray(value); if ( key === 'animationName' && value && (value.__radiumKeyframes || isKeyframeArray) ) { if (isKeyframeArray) { ...etc }

kylecesmat · 2018-08-22T01:35:12Z

src/plugins/keyframes-plugin.js

+            config.userAgent,
+          );
+          addCSS(css);
+          value = animationName;


can we reduce the duplicate logic here and extract this to a shared method?

ie:

const processKeyframeStyle = (value) => { const keyframesValue = (value: Keyframes); const { animationName, css } = keyframesValue.__process(config.userAgent); addCSS(css); return animationName; }

if (Array.isArray(value)) { value = value.map(processKeyframeStyle).join(', '); } else { value = processKeyframeStyle(value); }

Allow appveyor to run

kylecesmat · 2018-08-22T16:35:18Z

I believe you need to rebase/merge the upstream master branch. Looks like there is a merge conflict with the remote app.jsx

* Switch to `publishr` on npm registry publication. Fixes FormidableLabs#894 * Move `rimraf` to `devDependencies` on publish. * Rename + harmonize some npm scripts names.

* Supersedes and closes FormidableLabs#930 * Fixes FormidableLabs#928 * Actually lint our root JS config files. * Upgrade dev deps for React 16 * Fix tests. (And yowza there's some wonkiness with exception throwing...)

* Supersedes FormidableLabs#937 * Updates `React.createClass` calls to real ES `class`. * Refactor remaining `.jsx` suffixes to `.js` + configs. * Actually build the examples in CI.

* Fixes FormidableLabs#576 * Adds node tests for just the enhancer to get us at least a little bit of SSR testing * Improves the babel script commands

…false` wherein libraries can indicate their ESM re-exports are side effect free and can be much more efficiently removed for smaller, faster final bundles. (FormidableLabs#965) Lodash has already rolled out this change in https://unpkg.com/lodash-es@4.17.5/package.json ## Issues This was originally uncovered / discussed at length in: * webpack/webpack#1750 This PR should resolve the issues discussed in: * FormidableLabs/victory#549 * FormidableLabs/redux-little-router#262 ## Changes * Add `sideEffects: false` to `package.json` to allow webpack4 tree-shaking to actually remove all unused code. > This PR has been automatically opened by your friendly [`multibot`](https://github.com/FormidableLabs/multibot/). The transform code and documentation is available at: https://github.com/FormidableLabs/multibot-examples/tree/master/transforms/webpack-side-effects

- **Breaking Change**: Radium now exports defaults as `.default`, so for runtimes like Node.js for all files in `lib/**`. We have changed `package.json:main` to point to `/index.js` instead of `/lib/index.js` as a convenience wrapper to expose mostly what was there before so behavior of `const Radium = require('radium');` works mostly as it did before. Caveats: - Add `es` ESM module export files. - Fix `package.json:scrtips.postinstall` task to correctly work for git-based dependencies.

…#973 (FormidableLabs#974)

- Fixes FormidableLabs#738 - This is hacky, but possibly **acceptably** hacky. - Detect and transfer instance method properties from arrow functions to a copy of the prototype (where by definition they don't exist) to allow property inheritance call chaining by `RadiumEnhancer` which otherwise doesn't get its methods called.

Bug fix: render an array of elements * handle array child elements; ensure that extraStateKeyMap is cleaned up * Add regression test for render children.

* upgrade dev dependencies to latest react, ^16.2.0 * tests for fragments

Had an error wherein the right node version never got installed...

Fixes FormidableLabs#626

jaredbrookswhite · 2018-08-22T17:49:46Z

updated and done. sorry for the confusion, not in my normal dev environment today.

kylecesmat · 2018-09-17T02:01:48Z

This has been released in radium@0.25.0

Handle multiple animationName props

a725a2f

jaredbrookswhite mentioned this pull request Jul 13, 2017

How do I add multiple animations to keyframes? #675

Closed

kylecesmat previously requested changes Aug 22, 2018

View reviewed changes

jaredbrookswhite added 2 commits August 22, 2018 10:31

keyframes-plugin - Array check before if block

1a2e4eb

keyframes-plugin - reduce duplicate logic

e005b2a

jaredbrookswhite force-pushed the feature-multiple-animationName-props branch from e8630bd to 0839fe5 Compare August 22, 2018 16:33

jaredbrookswhite force-pushed the feature-multiple-animationName-props branch from 0839fe5 to 88a1e38 Compare August 22, 2018 16:34

jaredbrookswhite and others added 19 commits August 22, 2018 11:38

Prettier Compliance

88a1e38

Publishr publish workflow + tweaks. (FormidableLabs#914)

b001562

* Switch to `publishr` on npm registry publication. Fixes FormidableLabs#894 * Move `rimraf` to `devDependencies` on publish. * Rename + harmonize some npm scripts names.

Changelog for version 0.19.2

bfbde07

0.19.2

0c0f777

Remove publishr from npm package.json prod deps. (FormidableLabs#916)

c71c923

Changelog for version 0.19.3

50f1f4b

0.19.3

513fa21

Remove .babelrc for npm-published package. (FormidableLabs#917)

22e5064

Changelog for version 0.19.4

9fac011

0.19.4

171d514

Upgrade flow to 0.53.1

7ffe1f6

Fix style problems

1d86bff

Remove CSS-in-JS comparison table

8a047a7

Chore/react 16 upgrades (FormidableLabs#931)

f5212cd

* Supersedes and closes FormidableLabs#930 * Fixes FormidableLabs#928 * Actually lint our root JS config files. * Upgrade dev deps for React 16 * Fix tests. (And yowza there's some wonkiness with exception throwing...)

Changelog for version 0.19.5

d80be0b

0.19.5

33c05d4

Fix wrong link in Using Radium docs (FormidableLabs#934)

9788809

Update examples for React 16 (FormidableLabs#939)

8dbe3a7

* Supersedes FormidableLabs#937 * Updates `React.createClass` calls to real ES `class`. * Refactor remaining `.jsx` suffixes to `.js` + configs. * Actually build the examples in CI.

Bug: handle native ES classes. (FormidableLabs#936)

6d69232

* Fixes FormidableLabs#576 * Adds node tests for just the enhancer to get us at least a little bit of SSR testing * Improves the babel script commands

ryan-roemer and others added 27 commits August 22, 2018 11:55

Changelog for version 0.21.2

e082b8a

0.21.2

27a89cc

Changelog for version 0.22.0

d78ca25

0.22.0

ff7127b

Fix keyframes bug from prefixed inline styles. Fixes FormidableLabs…

0971d1c

…#973 (FormidableLabs#974)

Changelog for 0.22.1

1a94e1c

0.22.1

b11d9be

CHANGELOG for v0.23.0

b4d07d2

0.23.0

423f6aa

Bug fix: Render array of elements (FormidableLabs#979)

3246ff8

Bug fix: render an array of elements * handle array child elements; ensure that extraStateKeyMap is cleaned up * Add regression test for render children.

Test React Fragments (React 16.2.0) (FormidableLabs#980)

6556ab9

* upgrade dev dependencies to latest react, ^16.2.0 * tests for fragments

Changelog for 0.24.0

9325574

0.24.0

9793ff0

syntax highlighting & +;

c696fad

Update README.md

c3ff409

Fix appveyor. (FormidableLabs#991)

4bfa918

Had an error wherein the right node version never got installed...

Make <StyleSheet> manually update <style> tag DOM (FormidableLabs#989)

244dd97

Fixes FormidableLabs#626

Changelog for 0.24.1

8d07a54

0.24.1

13ab673

Merge branch 'master' into feature-multiple-animationName-props

ebda5dd

Rebase Master onto branch and Update Examples

f0762ea

remove vestigial examples/app.jsx

70a1849

Merge branch 'master' into feature-multiple-animationName-props

ae12486

Eslint compliance

f4a7e7d

kylecesmat merged commit 55a6965 into FormidableLabs:master Aug 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle multiple animationName props #909

Handle multiple animationName props #909

jaredbrookswhite commented Jul 13, 2017

coveralls commented Jul 13, 2017 •

edited

Loading

kylecesmat commented Aug 22, 2018 •

edited

Loading

kylecesmat left a comment

kylecesmat Aug 22, 2018

kylecesmat Aug 22, 2018

kylecesmat commented Aug 22, 2018

jaredbrookswhite commented Aug 22, 2018

kylecesmat commented Sep 17, 2018

Handle multiple animationName props #909

Handle multiple animationName props #909

Conversation

jaredbrookswhite commented Jul 13, 2017

coveralls commented Jul 13, 2017 • edited Loading

kylecesmat commented Aug 22, 2018 • edited Loading

kylecesmat left a comment

Choose a reason for hiding this comment

kylecesmat Aug 22, 2018

Choose a reason for hiding this comment

kylecesmat Aug 22, 2018

Choose a reason for hiding this comment

kylecesmat commented Aug 22, 2018

jaredbrookswhite commented Aug 22, 2018

kylecesmat commented Sep 17, 2018

coveralls commented Jul 13, 2017 •

edited

Loading

kylecesmat commented Aug 22, 2018 •

edited

Loading