-
Notifications
You must be signed in to change notification settings - Fork 308
Conversation
Note that Radium requires the use of keys. From the Guide...
That requirement still holds true with rendered arrays. (In fact, React requires keys for rendered arrays) |
The next step (can be in a different PR) will be testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, rest LGTM.
src/resolve-styles.js
Outdated
@@ -385,6 +385,34 @@ resolveStyles = function( | |||
); | |||
} | |||
|
|||
// TODO HERE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clean up all TODO
notes 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent 🤘
Merging. Will tackle testing |
Bug fix: render an array of elements * handle array child elements; ensure that extraStateKeyMap is cleaned up * Add regression test for render children.
React 16 introduced rendering arrays of elements.
This usage threw an error in Radium: #950