Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Test React Fragments (React 16.2.0) #980

Merged
merged 2 commits into from
Mar 29, 2018
Merged

Test React Fragments (React 16.2.0) #980

merged 2 commits into from
Mar 29, 2018

Conversation

chrisbolin
Copy link
Contributor

@chrisbolin chrisbolin commented Mar 29, 2018

Tests for React Fragments, which were part of react@16.2.0.

By necessity this upgrades our dev deps to react@16.2.0 (and react-dom and react-test-renderer)

Note that Radium (not React) requires keys on children, even if they are in a Fragment. This was also the case with normal children of a parent element, like a div.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.616% when pulling 2a7107a on react-fragments into 7ee95cb on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.616% when pulling 2a7107a on react-fragments into 7ee95cb on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.616% when pulling 2a7107a on react-fragments into 7ee95cb on master.

@chrisbolin chrisbolin changed the title Test React Fragments (16.2.0) Test React Fragments (React 16.2.0) Mar 29, 2018
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Great work!!!

@chrisbolin chrisbolin merged commit 4d52604 into master Mar 29, 2018
jaredbrookswhite pushed a commit to jaredbrookswhite/radium that referenced this pull request Aug 22, 2018
* upgrade dev dependencies to latest react, ^16.2.0

* tests for fragments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants