Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Remove CSS-in-JS comparison table #927

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Remove CSS-in-JS comparison table #927

merged 1 commit into from
Sep 19, 2017

Conversation

alexlande
Copy link
Contributor

Resolves #926

@paulathevalley: Could you help me deploy this change to http://formidable.com/open-source/radium/docs? Not sure what our process is for that nowadays.

@coveralls
Copy link

coveralls commented Sep 16, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 96.236% when pulling aec7a63 on chore-removeComparisonTable into 905227c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.236% when pulling aec7a63 on chore-removeComparisonTable into 905227c on master.

ryan-roemer
ryan-roemer approved these changes Sep 16, 2017
View reviewed changes
Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can help you with the deployment on Monday if @paulathevalley is unavailable.

@ryan-roemer
Copy link
Member

@paulathevalley @alexlande -- For the upstream -docs repo, let's also change our dep on radium here https://github.com/FormidableLabs/radium-docs/blob/master/package.json#L36 to actually hard pin a specific version like here https://github.com/FormidableLabs/formidable-playbook-docs/blob/master/package.json#L45

For reference, here's my "catch up infrastructure and stuff" PR for formidable-playbook-docs that may have some useful tidbits for radium-docs: https://github.com/FormidableLabs/formidable-playbook-docs/pull/29/files (Not completely analogous builds though...)

@paulathevalley
Copy link
Contributor

Yes! I can help deploy these changes today.

@alexlande alexlande merged commit 4c238eb into master Sep 19, 2017
@alexlande alexlande deleted the chore-removeComparisonTable branch September 19, 2017 18:09
@paulathevalley paulathevalley mentioned this pull request Sep 21, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryan-roemer ryan-roemer ryan-roemer approved these changes

@paulathevalley paulathevalley paulathevalley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexlande @coveralls @ryan-roemer @paulathevalley