New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V6 ontap callback #199
V6 ontap callback #199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add onTap to the README and the migration docs?
migration.md
Outdated
|
||
## Major Changes | ||
|
||
- removal of `<Swipeable>` component | ||
- _TODO_ add example for creating one and migrating | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 add new section for New Features
and add this to that list, and remove from migrate section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added to New Features
section
* remove Swipeable component src * remove proptype dep * overhaul tests and use react testing library (#186) * clean up some deps, bundle with microbundle (#187) * v6 start typescript overhaul (#188) * V6 typescript examples (#193) * instead of testing if xy values are false, see if they are undefined * V6 ontap callback (#199) * V6 verify velocity (#202) * move types to separate file, re-order property destructuring (#207) * V6 passive event solution (#210) * 6.0.0-alpha.0 * V6 type exports readme updates (#211) * 6.0.0-alpha.0 * migration guide, readme, type exports, prettier run on test * 6.0.0-alpha.1 * import React so the TS-compiler doesn't insert a global scope (#213) * upgrade peer to include react17, update docs * 6.0.0-alpha.2 Co-authored-by: Urmit Patel <urmit.patel@formidable.com> Co-authored-by: Jovi De Croock <jovi.decroock@formidable.com>
Add support for an
onTap
prop along with an appropriate example.