import React so the TS-compiler doesn't insert a global scope #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartzis
added a commit
that referenced
this pull request
Nov 6, 2020
* remove Swipeable component src * remove proptype dep * overhaul tests and use react testing library (#186) * clean up some deps, bundle with microbundle (#187) * v6 start typescript overhaul (#188) * V6 typescript examples (#193) * instead of testing if xy values are false, see if they are undefined * V6 ontap callback (#199) * V6 verify velocity (#202) * move types to separate file, re-order property destructuring (#207) * V6 passive event solution (#210) * 6.0.0-alpha.0 * V6 type exports readme updates (#211) * 6.0.0-alpha.0 * migration guide, readme, type exports, prettier run on test * 6.0.0-alpha.1 * import React so the TS-compiler doesn't insert a global scope (#213) * upgrade peer to include react17, update docs * 6.0.0-alpha.2 Co-authored-by: Urmit Patel <urmit.patel@formidable.com> Co-authored-by: Jovi De Croock <jovi.decroock@formidable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we were referencing React but not importing it the compiler saw it as a global which adds it as a reference.