Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 verify velocity #202

Merged
merged 12 commits into from Sep 7, 2020
Merged

V6 verify velocity #202

merged 12 commits into from Sep 7, 2020

Conversation

upatel32
Copy link
Contributor

Made velocity a vector based on the delta divided by time.

Add unit tests for new velocity.

@upatel32 upatel32 linked an issue Aug 25, 2020 that may be closed by this pull request
@upatel32 upatel32 self-assigned this Aug 25, 2020
@upatel32
Copy link
Contributor Author

Change velocity back to what it originally was, and the vector can be added as vxvy as a new prop. Clarify velocity in the docs that it is "absolute velocity" (speed).

@upatel32 upatel32 changed the base branch from v6-fix-deltas to v6 August 28, 2020 13:56
@hartzis hartzis merged commit 5700f85 into v6 Sep 7, 2020
@hartzis hartzis deleted the v6-verify-velocity branch September 7, 2020 22:48
hartzis added a commit that referenced this pull request Nov 6, 2020
* remove Swipeable component src

* remove proptype dep

* overhaul tests and use react testing library (#186)

* clean up some deps, bundle with microbundle (#187)

* v6 start typescript overhaul (#188)

* V6 typescript examples (#193)

* instead of testing if xy values are false, see if they are undefined

* V6 ontap callback (#199)

* V6 verify velocity (#202)

* move types to separate file, re-order property destructuring (#207)

* V6 passive event solution (#210)

* 6.0.0-alpha.0

* V6 type exports readme updates (#211)

* 6.0.0-alpha.0

* migration guide, readme, type exports, prettier run on test

* 6.0.0-alpha.1

* import React so the TS-compiler doesn't insert a global scope (#213)

* upgrade peer to include react17, update docs

* 6.0.0-alpha.2


Co-authored-by: Urmit Patel <urmit.patel@formidable.com>
Co-authored-by: Jovi De Croock <jovi.decroock@formidable.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert velocity into a vector
2 participants