Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

LOCATION_CHANGED action doesn't remember the query when going back (POP) #233

Closed
merisbahti opened this issue Sep 22, 2017 · 2 comments
Closed

Comments

@merisbahti
Copy link

merisbahti commented Sep 22, 2017

When moving back to a location with query-parameters, the router seems to have omitted the query-parameters the initial LOCATION_CHANGED-action was called with (even though the POP-action has the query-parameters)

I've included below which actions have to be dispatched to reproduce the issue.

ROUTER_LOCATION_CHANGED {param: "foo"}
ROUTER_PUSH {param: "bar"}
ROUTER_LOCATION_CHANGED {param: "bar"}
ROUTER_POP {param: "foo"}  // Why does this have {param: "foo"} and the next action doesn't?
ROUTER_LOCATION_CHANGED undefined  // Expected: ROUTER_LOCATION_CHANGED {param: "foo"}
@jahed
Copy link

jahed commented Oct 14, 2017

Same as #211

@tptee
Copy link
Contributor

tptee commented Oct 18, 2017

Yep, duplicate of #211 which is a high-pri bug!

@tptee tptee closed this as completed Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants