Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infra (CI/CD): Do dry run (fake) deployment to testing subdirectory in formidable.com bucket. #791

Merged
merged 10 commits into from Jan 10, 2020

Conversation

ryan-roemer
Copy link
Member

@ryan-roemer ryan-roemer commented Jan 8, 2020

Work

  • Fix the routes build logic to properly produce docs sidebar.
  • Add docs checks + build to CI.
  • Does a --dryrun simulated run on merging to a temporary open-source/spectacle-TODO-TESTING subdirectory in real production s3 bucket.

Tasks to complete

  • Ticket or implement a staging per-PR deploy step. Could be netlify or surge.
  • Add a deploy step that at least echoes something or maybe does an AWS --dryrun to the formidable s3 bucket.
  • Deploy to something like https://formidable.com/open-source/spectacle-TEMP/ to check if it comes up (it will be somewhat broken because of routes but we'd just check that files got there, not that they'd work).
  • Ticket out remaining work needed (in formidable.com repo and in this one).

... rest of tickets captured to #793

@ryan-roemer ryan-roemer changed the title WIP: Docs CI/CD work. Docs CI/CD work. Jan 9, 2020
@ryan-roemer ryan-roemer changed the title Docs CI/CD work. Infra (CI/CD): Do dry run (fake) deployment to testing subdirectory in formidable.com bucket. Jan 9, 2020
docs/README.md Outdated
Then, set up `aws-vault` with the AWS access and secret keys for `spectacle` CI in the `AWS IAM (formidable-com)` entry in the IC vault:

```sh
$ brew install aws-vault
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When going through these steps I was prompted to brew cask install aws-vault. Should this line be changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Good catch!

@boygirl
Copy link
Contributor

boygirl commented Jan 9, 2020

@ryan-roemer I went through the dryrun described in the docs readme, and everything works well for me.

@kale-stew
Copy link
Contributor

I was prompted to set a new password for the keychain after entering the two keys. 🤔 Is this expected behavior?

Screen Shot 2020-01-09 at 4 00 31 PM

@ryan-roemer
Copy link
Member Author

@boygirl I went ahead and did the surge deployment addition and it looks good. Current staging site is available at:

https://formidable-com-spectacle-staging-791.surge.sh/open-source/spectacle/

@ryan-roemer ryan-roemer merged commit 6b2edcd into master Jan 10, 2020
@ryan-roemer ryan-roemer deleted the task/docs-ci branch January 10, 2020 17:52
kale-stew pushed a commit that referenced this pull request Jan 10, 2020
* Update deck.js (#686)

* Bump handlebars from 4.0.12 to 4.1.2 (#684)

* Clear setInterval in cWU

* Add test for clearInterval

* Update one-page.html to use spectacle 5 (#687)

* update one-page.html to use spectacle 5 - fixes CSSStyleDeclaration index property setter error

* remove markdown tabbing to render properly

* undo ridiculous indentation from prettier

* update README to use Spectacle 5

* Minor dependency updates (#701)

* Add contentWidth and contentHeight to DeckProps (#699)

* Add bulletStyle types, doc updates (#703)

* Add bulletStyle types

* Fix ListProps type

* Add new COC contact email

* 5.6.0

* 5.7.0

* Fix transitionDuration prop for Slide component (#690)

* Add Spectacle Codemirror extension (#696)

* Update dependencies (#706)

* 5.7.1

* Document creating slide templates (#733)

* Use th for TableHeader (#744)

* add deck option to disable touch events (#745)

* fix 'inconsistency' spelling in README (#772)

* 5.7.2

* Sync spectacle-docs with main repo (#783)

* Copy & paste from spectacle-docs
* Move README content to docs & gut redundant blocks

* Readme++

* migrating from legacy GH services on to GH apps on travis (#785)

* Fix dead readme links (#784)

* Add react-static content for deploying docs (#786)

* Bump axios from 0.16.2 to 0.19.1 in /docs (#790)

* Make lint happy

* Infra (CI/CD): Do dry run (fake) deployment to testing subdirectory in formidable.com bucket. (#791)

* Change deploy.script to single line. (#795)

* Infra: Do real deploy to temp directory. (#796)

* Infra: Deploy to prod. Fix slug generation and numbers. (#797)

Co-authored-by: Kenzo <kenzoikeizume@hotmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Narin Luangrath <narin.luangrath@gmail.com>
Co-authored-by: Dominic C <domwork@live.com>
Co-authored-by: Max Cantor <i@cantor.mx>
Co-authored-by: Jonathan Fielding <jonathan-fielding@users.noreply.github.com>
Co-authored-by: Simon Fish <si@mon.fish>
Co-authored-by: Adam Gyulavari <azeroths@gmail.com>
Co-authored-by: Ilham Wahabi <wahabiputra@gmail.com>
Co-authored-by: Carlos Kelly <me@carlos.dev>
Co-authored-by: boygirl <lauren.eastridge@formidable.com>
Co-authored-by: Erik Thorelli <ethorelli@gmail.com>
Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants