Skip to content

Conversation

@ilhamwahabi
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

If my guess is right, 'inconstiency' is misspelled of 'inconsistency'.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist: (Feel free to delete this section upon completion)

  • My code follows the style guidelines of this project (I have run yarn prettier-fix && yarn lint)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (I have run yarn test)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated type definitions in index.d.ts for any breaking API changes

@kale-stew
Copy link
Contributor

Thank you for catching this error 🙂

@kale-stew kale-stew merged commit d24eb6b into FormidableLabs:master Nov 24, 2019
kale-stew pushed a commit that referenced this pull request Jan 10, 2020
* Update deck.js (#686)

* Bump handlebars from 4.0.12 to 4.1.2 (#684)

* Clear setInterval in cWU

* Add test for clearInterval

* Update one-page.html to use spectacle 5 (#687)

* update one-page.html to use spectacle 5 - fixes CSSStyleDeclaration index property setter error

* remove markdown tabbing to render properly

* undo ridiculous indentation from prettier

* update README to use Spectacle 5

* Minor dependency updates (#701)

* Add contentWidth and contentHeight to DeckProps (#699)

* Add bulletStyle types, doc updates (#703)

* Add bulletStyle types

* Fix ListProps type

* Add new COC contact email

* 5.6.0

* 5.7.0

* Fix transitionDuration prop for Slide component (#690)

* Add Spectacle Codemirror extension (#696)

* Update dependencies (#706)

* 5.7.1

* Document creating slide templates (#733)

* Use th for TableHeader (#744)

* add deck option to disable touch events (#745)

* fix 'inconsistency' spelling in README (#772)

* 5.7.2

* Sync spectacle-docs with main repo (#783)

* Copy & paste from spectacle-docs
* Move README content to docs & gut redundant blocks

* Readme++

* migrating from legacy GH services on to GH apps on travis (#785)

* Fix dead readme links (#784)

* Add react-static content for deploying docs (#786)

* Bump axios from 0.16.2 to 0.19.1 in /docs (#790)

* Make lint happy

* Infra (CI/CD): Do dry run (fake) deployment to testing subdirectory in formidable.com bucket. (#791)

* Change deploy.script to single line. (#795)

* Infra: Do real deploy to temp directory. (#796)

* Infra: Deploy to prod. Fix slug generation and numbers. (#797)

Co-authored-by: Kenzo <kenzoikeizume@hotmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Narin Luangrath <narin.luangrath@gmail.com>
Co-authored-by: Dominic C <domwork@live.com>
Co-authored-by: Max Cantor <i@cantor.mx>
Co-authored-by: Jonathan Fielding <jonathan-fielding@users.noreply.github.com>
Co-authored-by: Simon Fish <si@mon.fish>
Co-authored-by: Adam Gyulavari <azeroths@gmail.com>
Co-authored-by: Ilham Wahabi <wahabiputra@gmail.com>
Co-authored-by: Carlos Kelly <me@carlos.dev>
Co-authored-by: boygirl <lauren.eastridge@formidable.com>
Co-authored-by: Erik Thorelli <ethorelli@gmail.com>
Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants