Add contentWidth and contentHeight to DeckProps #699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs call for a number but strings (i.e. 95vw) seem to work fine. FormidableLabs#361 suggested a problem but that code doesn't seem to exist anymore.
4 tasks
kale-stew
pushed a commit
that referenced
this pull request
Jan 10, 2020
* Update deck.js (#686) * Bump handlebars from 4.0.12 to 4.1.2 (#684) * Clear setInterval in cWU * Add test for clearInterval * Update one-page.html to use spectacle 5 (#687) * update one-page.html to use spectacle 5 - fixes CSSStyleDeclaration index property setter error * remove markdown tabbing to render properly * undo ridiculous indentation from prettier * update README to use Spectacle 5 * Minor dependency updates (#701) * Add contentWidth and contentHeight to DeckProps (#699) * Add bulletStyle types, doc updates (#703) * Add bulletStyle types * Fix ListProps type * Add new COC contact email * 5.6.0 * 5.7.0 * Fix transitionDuration prop for Slide component (#690) * Add Spectacle Codemirror extension (#696) * Update dependencies (#706) * 5.7.1 * Document creating slide templates (#733) * Use th for TableHeader (#744) * add deck option to disable touch events (#745) * fix 'inconsistency' spelling in README (#772) * 5.7.2 * Sync spectacle-docs with main repo (#783) * Copy & paste from spectacle-docs * Move README content to docs & gut redundant blocks * Readme++ * migrating from legacy GH services on to GH apps on travis (#785) * Fix dead readme links (#784) * Add react-static content for deploying docs (#786) * Bump axios from 0.16.2 to 0.19.1 in /docs (#790) * Make lint happy * Infra (CI/CD): Do dry run (fake) deployment to testing subdirectory in formidable.com bucket. (#791) * Change deploy.script to single line. (#795) * Infra: Do real deploy to temp directory. (#796) * Infra: Deploy to prod. Fix slug generation and numbers. (#797) Co-authored-by: Kenzo <kenzoikeizume@hotmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Narin Luangrath <narin.luangrath@gmail.com> Co-authored-by: Dominic C <domwork@live.com> Co-authored-by: Max Cantor <i@cantor.mx> Co-authored-by: Jonathan Fielding <jonathan-fielding@users.noreply.github.com> Co-authored-by: Simon Fish <si@mon.fish> Co-authored-by: Adam Gyulavari <azeroths@gmail.com> Co-authored-by: Ilham Wahabi <wahabiputra@gmail.com> Co-authored-by: Carlos Kelly <me@carlos.dev> Co-authored-by: boygirl <lauren.eastridge@formidable.com> Co-authored-by: Erik Thorelli <ethorelli@gmail.com> Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The docs call for a number but strings (i.e. 95vw) seem to work fine. #361 suggested a problem but that code doesn't seem to exist anymore.
Fixes # (issue)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
manually checked that it worked
Checklist: (Feel free to delete this section upon completion)
yarn prettier-fix && yarn lint)yarn test)index.d.tsfor any breaking API changes