New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: .fa-before #2695
Comments
Nice idea in a point of view, but the reason we use < i > < / i > is to don't mess with link word font family. |
Usage of It would be great if that could make it to the main package too! I didn't notice any drawbacks so far. Only simpler HTML and less CSS. |
It will cause issues with Btw it should be possible as soon as the |
The idea to put I've tried to find a justification on why the whole library is designed this way (ie. that you have to use a separate tag for the icon) but I haven't been able to, thus I assume it's because no one really thought of real world use cases. Markup such as |
Anyway, changing |
on the element that has the "fa" class. See FortAwesome/Font-Awesome#2695
I’m running into the same issue—for me, it’s dramatically better to not have those |
In font-awesome.css there is the following class:
and if someone wants to add an icon to a link for example:
<a href="" class="fa fa-some-icon">link</a>
then the wordlink
hasfont-family: FontAwesome;
and there is no way to change that other than by adding another class:.fa-before
.Therefore, I suggest adding
.fa-before
to the main package. It would applyfont-family: FontAwesome;
only to the:before
pseudo-element:New usage:
<a href="" class="fa-before fa-some-icon">link</a>
The text was updated successfully, but these errors were encountered: