Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fa class and font smoothing #6557

Closed
widoz opened this issue May 26, 2015 · 4 comments
Closed

fa class and font smoothing #6557

widoz opened this issue May 26, 2015 · 4 comments
Labels

Comments

@widoz
Copy link

widoz commented May 26, 2015

The attribute for the .fa class create smoothing even of other elements inside the tag. For example:

< a href="#" name="at_my_list_print" class="at-btn red fa fa-print">Print List< /a>

This make my text Print List even smooth, I don't know if it is correct or not but I think that would be better to leave to the dev the decision.

I changed it to

.fa:before {
-webkit-font-smoothing : antialiased;
-moz-osx-font-smoothing : grayscale;
}

@tagliala
Copy link
Member

Could you please fix the example?

http://jsfiddle.net/tagliala/e9yfxsfj/

@widoz
Copy link
Author

widoz commented May 26, 2015

Here the fix

http://jsfiddle.net/e9yfxsfj/15/

@tagliala
Copy link
Member

This is not how fontawesome is supposed to work

Of course you can use it in this way if you need, but you also need to customize your stylesheet. At the moment we will keep css rules in the .fa class

Refers to #6223 #5082 (comment) #2695 #1729

Closing here, hope it helps. Thanks for your understanding

PS: This thing may change in the future

@leoyli
Copy link

leoyli commented Oct 25, 2017

I also want to address this in #11670. Even I use FA as suggested, I also don't expect that FA overwrite the style in <span class="fa-li fa fa-check-square"></span>. Because it should only rule the icon, not anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants