Apply fa-spin to :before pseudoelement

[chderen]

Hi,

should the spin apply only on the icon it's self?
i mean use .fa-spin:before instead of .fa-spin.

Thanks

[tagliala]

Are you asking this because of: http://jsfiddle.net/tagliala/77re29ct/26/ ?

Normally you should not add text in the same tag of icon, but if you are using semantic html let's talk about this

[chderen]

http://jsfiddle.net/xq1m2rLk/

[tagliala]

hmmm it makes sense.

Don't know what to do. I will plan this for 5.0.0 so dave will eventually take a look

[chderen]

Thank you

On Tue Dec 02 2014 at 00:19:35 Geremia Taglialatela <
notifications@github.com> wrote:

hmmm it makes sense.

Don't know what to do. I will plan this for 5.0.0 so dave will eventually
take a look

—
Reply to this email directly or view it on GitHub
#5082 (comment)
.

[tagliala]

We were forgetting about stacked icons: http://jsfiddle.net/tagliala/77re29ct/28/

I suppose that it is the main reason.

[chderen]

That can be achieved by
.fa-spin > :before
or
.fa-spin.fa-stack > :before

http://jsfiddle.net/77re29ct/31/

[rjgotten]

I suppose that it is the main reason.

Not all browsers support CSS animations on generated content pseudo-elements. In particular; older versions of Webkit that many Android phones still have installed as Android browser.

I'd think that would be the main reason...

[tagliala]

@rjgotten thanks

Moreover,

.fa-spin.fa-stack > :before

will add multiple animations

I should suggest to use a wrap tag in this case

http://jsfiddle.net/xq1m2rLk/2/

Closing here