-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with Meteor.js, http://meteor.com #5062
Integration with Meteor.js, http://meteor.com #5062
Conversation
Package.onUse(function (api) { | ||
api.versionsFrom('METEOR@0.9.2.1'); | ||
api.addFiles([ | ||
'fonts/FontAwesome.otf', // TODO What exactly does this file do? Can we get rid of it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the file used by dave for font development, all other files are generated from this one via fontsquirrel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file should not be needed, it is not used by the css
64b03d1
to
1550620
Compare
Also improve tests, publishing, README Link in the main README to the Meteor README after the Component section
1550620
to
ea02987
Compare
@dandv I will not do that, I would leave all the files required by the stylesheet for a bullet proof font face declaration: http://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/ Moreover, IE uses the .eot because AFAIK it only reads the first if fontawesome claims to support IE8, at least it should be possibile to opt-out instead of opt-in. And the css would need adjustment too. Last but not least, FA 5.0.0 should come with woff2 format, only supported by chrome at the moment: http://caniuse.com/#feat=woff2 |
@tagliala - good point. Last commit updates the |
@tagliala: updated that, thanks. Anything else? |
Yes... There is another thing I just noticed README.md is automatically generated from this file: https://github.com/FortAwesome/Font-Awesome/blob/master/src/README.md-nobuild so you should edit that one and rebuild via jekyll (yes, I know, #1166 (comment)) |
Done, please check. |
👍 it should be ok now |
Last commit adds the spacejam package to automate tests for Meteor, and also simplified the shell scripts. Looking forward to the merge. |
Dear all, I've made it as lean as possible so not to pick up too much space within your repository: basically it adds only a As you requested I've filed it for the If I may say, having it merged now on the Thanks in advance for your availability and collaboration and congratulation for the awesome project! Luca |
Closing here in favour of #5543 Feel free to comment if there is something wrong |
Hi Dave, Geremia,
I'm a package maintainer for Meteor.js, the most popular full-stack JavaScript framework.
Meteor devs love FontAwesome. So much in fact that we have at least two wrapper packages for it, which we had to update every time you updated Font Awesome upstream.
This PR will allow you to directly publish updated versions of FA as they become available. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account(s), and I'll add you as maintainer(s).
I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions, you'll be able to publish them to Atmosphere by running
meteor/publish.sh
.Thanks & best regards,
Dan