Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Meteor.js, http://meteor.com #5062

Closed

Conversation

dandv
Copy link

@dandv dandv commented Nov 26, 2014

Hi Dave, Geremia,

I'm a package maintainer for Meteor.js, the most popular full-stack JavaScript framework.

Meteor devs love FontAwesome. So much in fact that we have at least two wrapper packages for it, which we had to update every time you updated Font Awesome upstream.

This PR will allow you to directly publish updated versions of FA as they become available. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account(s), and I'll add you as maintainer(s).

I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions, you'll be able to publish them to Atmosphere by running meteor/publish.sh.

Thanks & best regards,
Dan

@tagliala tagliala added this to the 5.0.0 milestone Nov 26, 2014
Package.onUse(function (api) {
api.versionsFrom('METEOR@0.9.2.1');
api.addFiles([
'fonts/FontAwesome.otf', // TODO What exactly does this file do? Can we get rid of it?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the file used by dave for font development, all other files are generated from this one via fontsquirrel

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be needed, it is not used by the css

@dandv
Copy link
Author

dandv commented Nov 28, 2014

@tagliala: Thanks for the explanations re. fonts. I've updated the PR to create a separate compatibility package that bundles all fonts, and trimmed the regular package to only ship the woff.

Also improve tests, publishing, README

Link in the main README to the Meteor README after the Component section
@tagliala
Copy link
Member

@dandv I will not do that, I would leave all the files required by the stylesheet for a bullet proof font face declaration: http://www.paulirish.com/2009/bulletproof-font-face-implementation-syntax/

Moreover, IE uses the .eot because AFAIK it only reads the first src: .. declaration

image
Screenshot: IE11

if fontawesome claims to support IE8, at least it should be possibile to opt-out instead of opt-in. And the css would need adjustment too.

Last but not least, FA 5.0.0 should come with woff2 format, only supported by chrome at the moment: http://caniuse.com/#feat=woff2

@dandv
Copy link
Author

dandv commented Nov 28, 2014

@tagliala - good point. Last commit updates the package.js to load all fonts, and removes the font-compatibility package.

@dandv
Copy link
Author

dandv commented Nov 28, 2014

@tagliala: updated that, thanks. Anything else?

@tagliala
Copy link
Member

Yes... There is another thing I just noticed

README.md is automatically generated from this file: https://github.com/FortAwesome/Font-Awesome/blob/master/src/README.md-nobuild

so you should edit that one and rebuild via jekyll (yes, I know, #1166 (comment))

@dandv
Copy link
Author

dandv commented Nov 28, 2014

Done, please check.

@tagliala
Copy link
Member

👍 it should be ok now

@dandv
Copy link
Author

dandv commented Dec 15, 2014

Last commit adds the spacejam package to automate tests for Meteor, and also simplified the shell scripts. Looking forward to the merge.

@tagliala
Copy link
Member

@dandv is there something you can do about #5533 ?

@splendido
Copy link

Dear all,
I've just created a new PR for this: see #5543.

I've made it as lean as possible so not to pick up too much space within your repository: basically it adds only a pacakge.js file among the ones already present for the other PMs.
Moreover there will be no need to run commands (nor scripts) on your machine on new builds because everything will be managed by autopublish.meteor.com (if you follow a few more instructions I've written in the PR's OP).

As you requested I've filed it for the 5.0.0-wip branch but it would work flowlessly also for the current release. So feel free to merge it into the master branch if you feel comfortable with it!

If I may say, having it merged now on the master branch would permit to avoid seeing other issues like #5533 being opened in case you'll make new releases before the 5.0.0 one.

Thanks in advance for your availability and collaboration and congratulation for the awesome project!

Luca

@tagliala tagliala removed the feature label Jan 31, 2015
@tagliala tagliala removed this from the 5.0.0 milestone Jan 31, 2015
@tagliala
Copy link
Member

Closing here in favour of #5543

Feel free to comment if there is something wrong

@tagliala tagliala closed this Jan 31, 2015
@splendido splendido deleted the meteor-integration-5.0.0 branch August 9, 2015 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants