Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate offline LLM for searching media in gallery #19

Open
4 tasks done
shamirahim111 opened this issue Dec 24, 2023 · 16 comments
Open
4 tasks done

integrate offline LLM for searching media in gallery #19

shamirahim111 opened this issue Dec 24, 2023 · 16 comments
Labels
feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up

Comments

@shamirahim111
Copy link

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • [x I have read and understood the contribution guidelines.

Is your feature request related to a problem? Please describe.
there is no "LLM" or the buzzword "AI" in gallery. While this might be difficult to do on its own, there is a real problem of finding photos of something i took last month or photos of a friend or something.

Describe the solution you'd like
https://github.com/slavabarkov/tidy
this app exists and i've been using it for quite some time and it is very nice. the UX is "not" up to the quality of gallery so i was hoping if tidy could be integrated in gallery itself so that you can use the existing search that you have and the app would filter results. That's all i am asking for.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@shamirahim111 shamirahim111 added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Dec 24, 2023
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Dec 24, 2023
@naveensingh
Copy link
Member

We'll maybe do this eventually once there are more lightweight and efficient solutions available for this (I'm yet to do any actual research on this but a lighter solution shouldn't take long given the pace things are advancing).

I haven't done any work with Open AI clip specifically (used by tidy):
The tidy APK is 157MB so I'm guessing the model that is being used for this is too big even after quantization. I think most people do not want to download a 150MB gallery even if storage and bandwidth are relatively cheap now a days.

We could try this as an extension app for Gallery if enough people want it.

@shamirahim111
Copy link
Author

@naveensingh i understand the idea but i for one really "desire" this feature. how about a setting inside the app itself that downloads the model and does its thing?

@shamirahim111
Copy link
Author

#20

have started a poll

@test2a test2a mentioned this issue Dec 28, 2023
5 tasks
@jherazob
Copy link

jherazob commented Jan 5, 2024

I started using Simple Gallery because it was A SIMPLE GALLERY APP, adding this kind of thing is blatantly unnecessary bloat, the example you mention is 157Mb! And there's no reducing this any further, it's a fundamentally heavy application completely unnecessary for the tasks of A SIMPLE GALLERY APP.

@test2a
Copy link

test2a commented Jan 5, 2024

@jherazob i would say the gallery job itself is being done nicely so like @naveensingh is saying, maybe we can do this as an extension app outside of the normal app so that people who need the enhanced functionality can still continue to use the app

@johnnynoone
Copy link

@shamirahim111 I like the idea of optionally downloading the model in the settings. This way language-specific models can be offered in the future - not everyone speaks English.

@GfEW
Copy link

GfEW commented Feb 16, 2024

Agreed, if you decide to include such "useful bloat" (even if it's become lighter by then), please make it modular.

I'd like to add that "AI" search is not only heavier than, but also not generally superior to strict pattern matching. Just think of finding (or counting, examining, sharing etc.) all items that exactly match your carefully crafted search input, in any LLM driven search - you'll have a hard time.

Therefore, even when the user activates LLM search, strict pattern matching should remain available at hand, without jumping through hoops (like e. g. first having to dive into settings, find the appropriate option there, change it, leave settings, to finally being able to perform the actual search).

@inson1
Copy link
Contributor

inson1 commented Feb 16, 2024

@johnnynoone you cant do that, the app would need internet access, it has to be another app

EDIT max link would be possible

@haldi4803
Copy link

haldi4803 commented Feb 20, 2024

Here is another example of a fullfetched Gally with included CLIP search.
https://github.com/greyovo/PicQuery

I think that (or similar) needs to be included in any gallery in the "Future".
The Question is would that be now, in 2 years or in 5 years.

@inson1
Copy link
Contributor

inson1 commented Feb 20, 2024

yes, but the app is huge 175 mb apk, how much would be the app? 350-400 mb? that has to be different and optional app

or wait for smaller size

@haldi4803
Copy link

or... sepparate loading of AI model.

@inson1
Copy link
Contributor

inson1 commented Feb 20, 2024

@haldi4803 from where? No internet access

@haldi4803
Copy link

The Manual way... download the CLIP file you want from huggingface, and then select it in the app from the download location.
But that would be more than just "simple"

@inson1
Copy link
Contributor

inson1 commented Feb 21, 2024

@haldi4803 yea I guess the easiest way is to wait (as there is lot of work elsewhere anyway) or second app with it

@johnnynoone
Copy link

@johnnynoone you cant do that, the app would need internet access, it has to be another app

Oh, right. Then perhaps an extension installed separately from F-Droid? Just like the "OsmAnd Contour lines" extension for OsmAnd? Then it could be used in multiple Fossify apps, e.g. in the file manager.

@Aga-C Aga-C added the needs triage Issue is not yet ready for PR authors to take up label May 3, 2024
@Panak252
Copy link

Panak252 commented Oct 6, 2024

I'm not an android app developer so I wouldn't know if what I'm about to recommend makes any sense, but here's my idea:

A fork/variant of the gallery app could be made with modularity in mind, that allows for adding modules like image analysis (for objects, colours, whatever) and others, which can be "plugged in" (think of HDMI port connector covers) in such a way that allows for it to function both without any modules, as well as with any modules that come to mind.

This is just a thought, should something like this be considered desirable by both the developers and the users. This idea probably has flaws, but I believe you get the gist of it ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up
Projects
None yet
Development

No branches or pull requests

10 participants