0.3.27 - language support/i translate #362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a pixel cut in floating-toolbar
…es/app/nylas.png The icon build/resources/nylas.png is exactly the same as build/resources/linux/icons/512.png Not confident that the spec script is run from base N1 directory to use the nylas.png in the spec file
As mentioned on this Electron's issue: electron/electron#2777 The 'activate-with-open-windows' event has been deprecated in favor of a global 'activate' event with a 'hasVisibleWindows' parameter. This fixes Nylas from crashing when closing the main window and opening via clicking the Dock icon.
Removing deprecated 'activate-with-no-open-windows' event
Summary: This diff: - Improves the styling of the tabs in the preferences sidebar. - Adds an optional param to section cofnig that puts an "account" submenu beneath the tab item. - Renames preferences "sections" => "tabs", and renames the PreferencesSectionStore to PreferencesUIStore. I think we should include "UI" in more of our stores, and I think "tabs" is a good idea because it's unambigious—there's no way you could confuse it for a "section" of the NylasEnv.config tree or think it deals with actually saving prefs. Test Plan: Inspect visually Reviewers: evan, juan Reviewed By: evan Differential Revision: https://phab.nylas.com/D2296
Summary: Add signatures back in. Extract contenteditable css to its own file instead of being bundled with the composer. Test Plan: manual Reviewers: juan, bengotow Reviewed By: bengotow Differential Revision: https://phab.nylas.com/D2295
fix(rpm): copy N1 icons into hicolor folder
The linux CI server @ Nylas is running debian wheezy, which is too old to run N1 / Electron 0.35+. We need to switch to making the builds with Travis or https://packagecloud.io/.
Event RSVPs would resend every time the app was opened, due to `resolve` never being called on the `Promise` after successfully sending an event RSVP.
|
Hey! Thanks for getting this started! It looks like this pull request may be comparing two existing branches of the project when you may mean to fork the project, create a branch of your own, and send a pull request for that one? |
|
Hey, I'm willing to help with the translate, but I'm not so pro with javascript. As much as I can do is get some strings and translate them, usually I use gettext for that, thing doesn't works in javascript as far as I know.
Can you give me a clue about how to get your strings and create a .po (or equivalent) file to give internationalitation? if you feel too tired for get this just ignore me
…--
We are not what we eat, we are what we decide
twitter.com/AbiertaMente
--
On nov. 25 2017, at 9:34 pm, Ben Gotow ***@***.***> wrote:
Hey! Thanks for getting this started! It looks like this pull request may be comparing two existing branches of the project when you may mean to fork the project, create a branch of your own, and send a pull request for that one?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub (#362?recipient=reply%2B00680c8679232a53e6a75a149ab1a03a5d4987d635cb78a592cf00000001163195bd92a169ce107e8cc9%40reply.github.com#issuecomment-346964387), or mute the thread (https://github.com/notifications/unsubscribe-auth/AGgMho3pWB_6IF5Wh_zSuLq0tPbEJHT6ks5s6Hm9gaJpZM4QqUsm?recipient=reply%2B00680c8679232a53e6a75a149ab1a03a5d4987d635cb78a592cf00000001163195bd92a169ce107e8cc9%40reply.github.com).
|
|
Hey! If that's the case, could you sign up on the Google form mentioned here? #226 We'll get started on the extraction of strings soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let me translate this app for es_ES