Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use calc_nl_2DQG! -- used calc_nl_2DQG instead #4

Closed
navidcy opened this issue Jul 5, 2017 · 1 comment
Closed

Can't use calc_nl_2DQG! -- used calc_nl_2DQG instead #4

navidcy opened this issue Jul 5, 2017 · 1 comment
Assignees
@glwagner
Labels
help wanted

Comments

@navidcy
Copy link
Member

navidcy commented Jul 5, 2017

branch:2DQGturb
file solver.jl
line 170

I tried to introduce an in-place-function calc_nl_2DQG!
It calculates NLqh correct but it does NOT update the qts.NL

Do you have any idea why?
@glwagner
Copy link
Member

glwagner commented Jul 6, 2017

I'll look into this. This is exactly the issue I was having when writing the solver for the hydrostatic wave equation. I want to get to the bottom of this.

@navidcy navidcy closed this as completed Nov 3, 2017
navidcy added a commit that referenced this issue Dec 27, 2018
@navidcy
corrects substep #4 of RK4 & FilteredRK4 timesteppers
9ae8735
@navidcy navidcy mentioned this issue Dec 27, 2018
Merged
navidcy added a commit that referenced this issue Apr 8, 2021
@navidcy
attempt #4
fb963ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glwagner glwagner

Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@navidcy @glwagner