Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@reexport using FourierFlows in GeophysicalFlows.jl? #33

Closed
navidcy opened this issue Sep 11, 2019 · 4 comments · Fixed by #229
Closed

@reexport using FourierFlows in GeophysicalFlows.jl? #33

navidcy opened this issue Sep 11, 2019 · 4 comments · Fixed by #229
Assignees

Comments

@navidcy
Copy link
Member

navidcy commented Sep 11, 2019

Why don't we call this

using Reexport
@reexport using FourierFlows

inside GeophysicalFlows.jl and instead we call it inside each module?

@glwagner
Copy link
Member

glwagner commented Sep 21, 2019

The question is whether users will typically write

using GeophysicalFlows

Or

using GeophysicalFlows.ModuleOfInterest

But maybe you have a point that it’s better to encourage “using GeophysicalFlows”, along with the pattern “prob = TwoDTurb.Problem(...)”

@navidcy
Copy link
Member Author

navidcy commented Nov 24, 2020

OK, I'm closing for now..

@navidcy navidcy closed this as completed Nov 24, 2020
@navidcy navidcy reopened this Apr 14, 2021
@navidcy
Copy link
Member Author

navidcy commented Apr 14, 2021

This issue is been brought back to the frontline inspired by @pdebuyl's remark in JOSS paper review.

A more streamlined approach to help users is to have GeophysicalFlows.jl re-export all functionality in FourierFlows.jl.

@glwagner
Copy link
Member

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants