Simplify examples #229
Merged
Simplify examples #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 tasks
glwagner
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Looks good.
Someday we may be able to combine functions like energy defined in different modules. We have to figure out a way to determine which physical problem a FourierFlows.Problem refers to (a simple way to achieve this would be to add type parameters to FourierFlows.Problem that identify the module it comes from...)
|
I guess if we do something like abstract type TwoDNavierStokesProblem <: AbstractProblem endand define the Then we can have energy(prob::TwoDNavierStokesProblem) = ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the examples. Now common functions from FFTW and CUDA packages are re-exported by FourierFlows. Also, FourierFlows namespace is reexported by GeophysicalFlows. Thus,
using GeophysicalFlowssuffices for running simulations. The users still need to load, e.g.,Plots.jlif they want to plot the output.(Inspired by @pdebuyl's remark in JOSS paper review.)
Closes #33.