Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate updatevars! for physical space and Fourier space #81

Closed
navidcy opened this issue May 27, 2020 · 2 comments
Closed

Separate updatevars! for physical space and Fourier space #81

navidcy opened this issue May 27, 2020 · 2 comments
Assignees

Comments

@navidcy
Copy link
Member

navidcy commented May 27, 2020

Updating variables in physical space requires an inverse Fourier transform, which in turns requires a deepcopy(). Sometimes, though, we only need to update the Fourier transform of variables. Therefore if we split updatevars! into two separate function we might gain on allocation.

@navidcy
Copy link
Member Author

navidcy commented Nov 23, 2020

@glwagner, how about something like 73bff09?

@navidcy
Copy link
Member Author

navidcy commented Nov 29, 2020

At the moment no module will benefit from this so I'm closing.

@navidcy navidcy closed this as completed Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant