Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Split updatevars!() for Fourier transformed variables #148

Closed
wants to merge 1 commit into from
Closed

[WIP] Split updatevars!() for Fourier transformed variables #148

wants to merge 1 commit into from

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Nov 27, 2020

Closes #81

@navidcy
Copy link
Member Author

navidcy commented Nov 27, 2020

@glwagner, I reckon you were thinking something like this, right?

glwagner
glwagner approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When was I thinking of something like this?

@navidcy
Copy link
Member Author

navidcy commented Nov 29, 2020 •
edited
Loading

haha, we were chatting about it over txt or call (I don't remember). And then I opened #81...

@navidcy
Copy link
Member Author

navidcy commented Nov 29, 2020

But now that I look closer it only makes sense for MultilayerQG and in particular for the fluxes diagnostics; I'l revise.

@navidcy navidcy closed this Nov 29, 2020
@navidcy navidcy deleted the ncc/split-updatevars branch February 25, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glwagner glwagner glwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate updatevars! for physical space and Fourier space
2 participants
@navidcy @glwagner