Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all tests/functions gpu-kernel friendly #143

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Nov 23, 2020

This PR closes #141 and other issues related to that (e.g., those related with constructing forcingspetrumcovariance).

This PR was made possible with the patience of @vchuravy on slack; thanks!

Also closes #121 and closes #130.

@navidcy navidcy changed the title [WIP] Make all tests/functions gpu-kernel friendly Make all tests/functions gpu-kernel friendly Nov 23, 2020
@navidcy
Copy link
Member Author

navidcy commented Nov 23, 2020

@glwagner, this is ready to review. All module pass the GPU tests again!

@navidcy navidcy added 🐞 bug Something isn't working 🎮 gpu labels Nov 23, 2020
Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All hail ifelse

@navidcy navidcy merged commit 60dc3f1 into master Nov 24, 2020
@navidcy navidcy deleted the ncc/fix-cuda-compliance branch November 24, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🎮 gpu
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subarray indexing problematic on GPU? GPU tests fail MultilayerQG fails GPU tests
2 participants