Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance examples + Fix some plot orientations #145

Merged
merged 10 commits into from
Nov 27, 2020
Merged

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Nov 23, 2020

This PR just goes through the example once again.

  • Μakes sure that fields are plotted with the correct orientation, e, g., heatmap(x, y, ζ) -> heatmap(x, y, ζ').
  • Changes $math$ to ``math`` for inline latex expressions.
  • Adds cfl in all example logs and make sure cfl is only computed whenever log is printed out.
  • Makes expressions more verbose, e.g., p, g, v, cl ->params, grid, vars, clock.
  • Beautifies code where possible.

A preview is found here: https://fourierflows.github.io/GeophysicalFlowsDocumentation/previews/PR145

Closes #134.

Copy link
Collaborator

@BrodiePearson BrodiePearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes look good to me.

@navidcy navidcy removed the request for review from glwagner November 27, 2020 20:38
@navidcy navidcy merged commit aa761bd into master Nov 27, 2020
@navidcy navidcy deleted the ncc/fixplotorientation branch November 27, 2020 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some of the animations have the axes flipped
2 participants