Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all animations in Docs from mp4 to gifs #157

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Dec 2, 2020

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love gif's! I usually use fps=8 but if you have a lot of output it makes sense to speed it up...

@navidcy
Copy link
Member Author

navidcy commented Dec 2, 2020

Do you reckon the animations go fast? They look good on my screen.

@navidcy navidcy removed the request for review from BrodiePearson December 2, 2020 20:00
@navidcy
Copy link
Member Author

navidcy commented Dec 2, 2020

(The only problem with gifs is that they are bigger in file size...)

@glwagner
Copy link
Member

glwagner commented Dec 2, 2020

I think you could decrease the number of outputs and change to fps=8 to speed up the runs, that's all.

@glwagner
Copy link
Member

glwagner commented Dec 2, 2020

Right, so decreasing the number of snapshots and also slowing the movies down to obtain a similar effect would also reduce the file size.

@navidcy
Copy link
Member Author

navidcy commented Dec 2, 2020

Well, the numbers here are the minimum that my eyes and brain feel good with. E.g., examples with stochastic forcing become too flickery...

(I did try to reduce output numbers at some point.)

But if you wanna have a go trying to reduce the numbers go for it :)

@navidcy
Copy link
Member Author

navidcy commented Dec 2, 2020

Damn... you got me started now :)

@glwagner
Copy link
Member

glwagner commented Dec 2, 2020

I think it's ok if the movies don't look "continuous". The question is not "how pretty" but "how useful", I think.

@navidcy
Copy link
Member Author

navidcy commented Dec 2, 2020

as pretty as one can get! :)

@navidcy
Copy link
Member Author

navidcy commented Dec 2, 2020

I'll merge now and we can work on this at some later time. Until then I'll try to keep cleaning the GeophysicalFlowsDocumentation repo.

@navidcy navidcy merged commit 9932129 into master Dec 2, 2020
@navidcy navidcy deleted the ncc/mp4-to-gif branch December 2, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animations in Docs don't show up in Safari
2 participants