-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to specify topographic PV large-scale gradients in MultiLayerQG
#313
Conversation
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
Sorry for slacking on this. I’m on holiday. |
No worries at all! Take your time. |
@apaloczy, I think it's good to go! Have a look at the docstrings additions I made and modify if needed. |
I believe I gave you write rights so you can merge. |
@apaloczy, I'm wondering whether there is a requirement that right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's think more whether the gradients of the non-periodic component of the PV have to be periodic
Giving this more thought, I doubt the non-periodic topo PV would work with anything but constant slope |
The equations themselves have to be periodic; otherwise the discontinuity at domain "edges" will cause simulations to blow up. |
@apaloczy I suggest we change What do you think? |
I had a go at it. Have a look. :) |
MultiLayerQG
MultiLayerQG
Sorry for the slowness here. I was offline for a couple of days myself. This all sounds great, I think having the large-scale topographic PV slopes as floats makes sense. It also makes sense that |
This closes #307 by adding options to specify a nonperiodic component of the topographic PV gradients (for example a planar slope) in the
MultiLayerQG
module. Also added one test.The gradients of the nonperiodic part of the topographic PV are now specified separately via
etax_nonperiodic
andetay_nonperiodic
inMultiLayerQG.Problem
, and are added to the gradients of the periodic part of the topographic PV (calculated via FFTs).